dulwich.client.get_transport_and_path sensitive to change in Python's urlparse.urlparse behaviour, causes test failures on <= karmic
Bug #707438 reported by
Max Bowsher
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Dulwich |
Fix Released
|
Medium
|
Max Bowsher |
Bug Description
dulwich.
Python's urlparse.urlparse behaviour concerning whether unknown protocols are handled in a netloc-aware manner has changed over time, and the result is that the behaviour of this function differs on <= karmic in ways that cause the testsuite to fail.
This is an obstruction to updating dulwich in the ~bzr PPA for <= karmic.
Related branches
lp:~maxb/dulwich/older-urlparse-compat
- Jelmer Vernooij (community): Approve (code)
-
Diff: 31 lines (+9/-1)2 files modifieddulwich/client.py (+6/-0)
dulwich/tests/test_client.py (+3/-1)
Changed in dulwich: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in dulwich: | |
status: | Triaged → Fix Committed |
assignee: | nobody → Max Bowsher (maxb) |
Changed in dulwich: | |
milestone: | none → 0.7.1 |
milestone: | 0.7.1 → none |
milestone: | none → 0.7.1 |
Changed in dulwich: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Sigh, I noticed that urlparse had some weird corner cases, but I thought it would at least be consistent. Can you give examples of URLs and the results of urlparse in different python versions?