Zoom level default and step preferences
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
To allow comfotable web viewing on wild varying screen sizes and resolution, there for sure should be ability to specify zoom settings:
1. Default zoom level for new tabs
2. Zoom increment step
Webkit's default zoom of 1.0 doesn't work for all screens. For example, on my 17" 1600x1050 laptop, for each new tab I have to press Ctrl++ couple of times - there're plenty of screen space, and my eyes are overloaded enough so I'd rather see big letters. And I'd imagine that on low-res device, like PDA or tablet, one would want to set default zoom <1.0, to be able to see as much web page without scrolling, and only then zoom in to read specific parts of it.
Same goes for zooming step - for specific screen resolutions, there may be big layout changes for default Midori's step of 0.25, like horizontal scrollbar appearance. So, it makes sense to let user specify custom increment, and be able to fine-tune zoom as fits them. Surprisingly, ChangeLog tells that there was zoom stepping preference, but it was removed in 0.1.0. What a loss, please add it back in!
Finally, there's an "Enforce 96 dots per inch" preference. It might be related to zoom, but surprisingly, it's not handled by the code in any way, as 0.2.9 (grepping for internal pref if of "enforce-96-dpi" gets only one hit).
Summing up, could we: 1) have zoom step pref back; 2) default zoom pref added; 3) confusing 96 dpi pref removed. Thanks.
Moved from FS: http://
Related branches
- André Stösel: Approve
-
Diff: 111 lines (+35/-1)5 files modifiedkatze/katze-utils.c (+16/-0)
midori/midori-preferences.c (+6/-0)
midori/midori-settings.vala (+2/-0)
midori/midori-view.c (+3/-0)
midori/midori-websettings.c (+8/-1)
Changed in midori: | |
status: | Fix Committed → Fix Released |
summary: |
- Allow flexible control over zoom level (default zoom level, increment - step) + Zoom level default and step preferences |
Changed in midori: | |
importance: | Low → Wishlist |
status: | In Progress → Confirmed |
tags: | added: preferences |
Changed in midori: | |
milestone: | none → 0.5.4 |
Changed in midori: | |
status: | Confirmed → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |
Actually, git log -p doesn't show that there was configurable zoom step in midori-view.c, midori-browser.c (btw, why there's duplicat code?) but rather change like:
- webkit_ web_view_ zoom_in (WEBKIT_WEB_VIEW (web_view)); view_set_ zoom_level (view, view_get_ zoom_level (view) + 0.25f);
+ midori_
+ midori_
Which is good of course, just instead of 0.25 there should be var from user prefs.
pfalcon