zero length pins are drawn incorrectly

Bug #706552 reported by Krzysztof Kościuszkiewicz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Unassigned

Bug Description

End marker of zero-length pins is drawn incorrectly (see attachment).

One choice would be to reuse unconnected net endpoint cue (square box) - see attached patch.
Another is to keep existing cue (marking on line end) for longer pins, and use square box for short/zero-length pins.

Related discussion can be found in comments to bug #705397.

Tags: gschem libgeda
Revision history for this message
Krzysztof Kościuszkiewicz (k-kosciuszkiewicz) wrote :
Revision history for this message
Krzysztof Kościuszkiewicz (k-kosciuszkiewicz) wrote :

Re-posting patch implementing option 1 (same cues as for unconnected net endpoints) from bug #705397.

Revision history for this message
Krzysztof Kościuszkiewicz (k-kosciuszkiewicz) wrote :

Fixed the patch - previous patch incorrectly marked all pin ends.

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

I really like the change this patch brings. It makes the end of unconnected pins look the same as unconneted end of nets, which is what they are. This is nice, because I am less likely to miss an accidently non-connected pin.

Is there anything that blocks the application of the first patch to git-head?

I am not so sure about the second patch the one that makes postscript output also have little boxes on open pins. Symbols with large not connected pin numbers would look a bit cluttered. Since postscript goes into documentation, I'd prefer the standard look. That is, without any marker at all.

---<)kaimartin(>---

Revision history for this message
Krzysztof Kościuszkiewicz (k-kosciuszkiewicz) wrote :

I have other work in progress related to pin-cues (#707064) and that's the sole reason why the patch is not commited yet.
I believe postscript output mirrors the screen output (modulo line ends/line joins) so I'm not sure why we'd want to deviate from that here - It seems more discussion is needed.
In the end if you want to mark the pin end as unconnected you can place a special symbol there just for the sake of documentation.

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

Common practice in printed circuits and data sheets is pin ends without a marker. IMHO, this is a valid reason to deviate from the rule to mirror screen output.

---<)kaimartin(>---

Revision history for this message
Krzysztof Kościuszkiewicz (k-kosciuszkiewicz) wrote :
Changed in geda:
status: New → Fix Committed
milestone: none → 1.8.0
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.