Make remove_translations side aware.

[Henning Eggers]

The script in lib/lp/translations/scripts/remove_translations.py is not yet side-aware. It needs to be looked at and most likely fixed before it can be run again.

[Abel Deuring (adeuring)]

I discussed this with Danilo yesterday. Our conclusion:

In its current state, the script "substitutes" a deleted message if deleted_message.is_current_ubuntu == True, and if another message exists for the same potemplate and same language where other_message.is_current_upstream == True. (Where "same potemplate" means that both message.potemplate IS NULL for both messages or deleted_message.potemplate==replacement_message.potemplate).

If such a message exists, its is_current_ubuntu flag will be set to True.

For all other cases, like deleting a message where is_current_upstream == True, or deleting a diverged message which is current in Ubuntu and where a shared message being current in Ubuntu exists, are not handled.

This _could_ probably be extended so that the deletion of a current message works more like an "undo" feature (based on the date_reviewed value of other translation messages for the same POTMsgSet and language).

But since the srcipt is used so rarely, it is not worth the implementation effort.

It might make sense though to report in the script which of the deleted messages had the flags is_current_(ubuntu|upstream) set. After all, this means that some POTMsgSets are suddenly untranslated.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12321 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12321>.