switch --up to --upa in case too many chunks

Bug #705452 reported by Elan Ruusamäe
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
poldek
Fix Committed
Undecided
Cactus

Bug Description

would be nice if poldek --up would switch automatically to poldek --upa mode if it sees that the applying by chunks would take longer than loading whole index.

this is especally needed for frequently updated indexes, like th-test

Cactus (uzi18)
Changed in poldek:
status: New → Confirmed
Revision history for this message
Elan Ruusamäe (glen666) wrote :

note that this would make the fd leak issue (bug #307183) more transparent, i.e not being relevant anymore :)

Revision history for this message
Cactus (uzi18) wrote :

Maybe we can check it by date?
i.e. after 1-2 days it is better to download via upa?

Revision history for this message
Marcin Banasiak (megabajt) wrote :

> Maybe we can check it by date?
> i.e. after 1-2 days it is better to download via upa?

No, it's not a good idea. We can't depend on date because repository can be updated once a day or even more often as well as less frequently, e. g. once a week. We really don't know this and we shouldn't force the user to download whole index while there is only one small diff available.

Revision history for this message
Cactus (uzi18) wrote :

ok now know how it works, i'll try to manage this bug

Revision history for this message
Cactus (uzi18) wrote :

Please test this patch

we add all data for master index (tested)
and all data every date/time patch (tested)
if we reach more update whole index ( not tested)

waiting for feedback

Revision history for this message
Cactus (uzi18) wrote :

ok patch's working for me

Cactus (uzi18)
Changed in poldek:
status: Confirmed → Fix Committed
assignee: nobody → Cactus (uzi18)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.