NameError: mailto on picture view in People reports

Bug #705171 reported by Jim B. Glenn
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
High
Tres Seaver

Bug Description

 Verified on multiple KARL sites.
When you click picture view on a people page, you get a General Error:

   <!--
       Traceback (most recent call last):
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/src/karl/karl/errorpage.py", line 51, in __call__
    resp = req.get_response(self.app)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/WebOb-0.9.8.0_osi1-py2.5.egg/webob/request.py", line 920, in get_response
    application, catch_exc_info=False)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/WebOb-0.9.8.0_osi1-py2.5.egg/webob/request.py", line 888, in call_application
    app_iter = application(self.environ, start_response)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.retry-0.9.4-py2.5.egg/repoze/retry/__init__.py", line 88, in __call__
    app_iter = self.application(environ, replace_start_response)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.tm2-1.0a5-py2.5.egg/repoze/tm/__init__.py", line 23, in __call__
    result = self.application(environ, save_status_and_headers)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Paste-1.7.2-py2.5.egg/paste/registry.py", line 350, in __call__
    app_iter = self.application(environ, start_response)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.who-1.0.15-py2.5.egg/repoze/who/middleware.py", line 107, in __call__
    app_iter = app(environ, wrapper.wrap_start_response)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.browserid-0.3-py2.5.egg/repoze/browserid/middleware.py", line 134, in __call__
    app_iter = self.app(environ, wrapper.wrap_start_response)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/router.py", line 130, in __call__
    response = view_callable(context, request)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1753, in _secured_view
    return view(context, request)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1708, in _rendered_view
    renderer_name)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/configuration.py", line 1562, in rendered_response
    'context':context, 'request':request})
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/repoze.bfg-1.2-py2.5.egg/repoze/bfg/chameleon_zpt.py", line 46, in __call__
    result = self.template(**system)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 83, in __call__
    return self.render(**kwargs)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 335, in render
    return super(TemplateFile, self).render(**kwargs)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/zpt/template.py", line 18, in render
    return super(PageTemplate, self).render(**kwargs)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 188, in render
    return self.cook_and_render(kwargs, utils.emptydict, None, True)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 315, in cook_and_render
    args, slots, macro, global_scope)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 180, in cook_and_render
    return func(econtext, rcontext)
  File "&lt;string&gt;", line 542, in render
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 379, in render
    return self.render(name, slots=slots, parameters=kwargs)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/zpt/template.py", line 23, in render_macro
    macro, global_scope=global_scope, slots=slots, parameters=parameters)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 198, in render_macro
    return self.cook_and_render(parameters, slots, macro, global_scope)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 315, in cook_and_render
    args, slots, macro, global_scope)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 180, in cook_and_render
    return func(econtext, rcontext)
  File "&lt;string&gt;", line 492, in render
  File "&lt;string&gt;", line 136, in _callback_content
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 379, in render
    return self.render(name, slots=slots, parameters=kwargs)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/zpt/template.py", line 23, in render_macro
    macro, global_scope=global_scope, slots=slots, parameters=parameters)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 198, in render_macro
    return self.cook_and_render(parameters, slots, macro, global_scope)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 315, in cook_and_render
    args, slots, macro, global_scope)
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/template.py", line 180, in cook_and_render
    return func(econtext, rcontext)
  File "&lt;string&gt;", line 27, in render
  File "/opt/karlstaging/karl/sixfeetupkarl/3.3.1-0/eggs/Chameleon-1.1.1-py2.5.egg/chameleon/core/utils.py", line 294, in __getitem__
    raise NameError(key)
NameError: mailto

     -->

            <!--

Tags: r3.54
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Tres, the picture view on People reports is broken. E.g. http://staging.osi.sixfeetup.com/people/osi/c1/r1/baltimore-office/picture_view.html

Need to get a fix out tomorrow if we can. Probably quick to fix.

Changed in karl3:
assignee: nobody → Tres Seaver (tseaver)
importance: Undecided → High
milestone: none → m52
summary: - General error on picture view of all profile pages
+ NameError: mailto on picture view in People reports
Tres Seaver (tseaver)
Changed in karl3:
status: New → In Progress
Revision history for this message
Tres Seaver (tseaver) wrote :

Fix committed, with additional tests.

Note that the unit tests didnt catch this because they don't exercise
rendering the template. Full-coverage selenium or twill tests would have
caught the bug.

Changed in karl3:
status: In Progress → Fix Committed
Tres Seaver (tseaver)
Changed in karl3:
status: Fix Committed → Fix Released
JimPGlenn (jpglenn09)
tags: added: r3.54
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.