Doesn’t compile without swfdec-gtk

Bug #704672 reported by Emmanuel Gil Peyrot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ella
Fix Released
Undecided
Unassigned

Bug Description

The support of flash should be optional in Ella, because a lot of people want to use it as an animated SVG editor only.
A configure option to choose to enable flash or not should be added, but I think it isn’t the subject of this bug.

Revision history for this message
Emmanuel Gil Peyrot (linkmauve) wrote :
description: updated
Revision history for this message
Kevlar (amiluc-bis) wrote :

yes but at this time, you can't have any preview because the player is made upon Swfdec ...

Revision history for this message
xapantu (xapantu) wrote : Re: [Ella-animation] [Bug 704672] Re:Doesn’tcompile without swfdec-gtk

@kevlar: Hum, we should implement the preview *in* the editor, it would
be the best thing to do.

@Emmanuel: Thanks :)
For your patch: you use a macro, _WITH_FLASH, and it doesn't compile
with swfdec if it is not defined. I would prefer a macro to disable it
instead of a macro to enable it. At least, at this moment, because,
there is not any preview system without swfdec.

So, something like "#ifndef NO_FLASH" would be better.

The build system needs also some modification, but I can do that :)

Revision history for this message
Emmanuel Gil Peyrot (linkmauve) wrote :

Here are the corrections.

Revision history for this message
xapantu (xapantu) wrote :

Just for archive, I applied it a few weeks ago.

Changed in ella:
status: New → Fix Committed
milestone: none → 0.3.2
xapantu (xapantu)
Changed in ella:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.