bugmessage.index is not populated
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Robert Collins |
Bug Description
BugMessage.index exists in the schema to let BugTask:+index be more efficient, but its not populated.
To populate it we need a multistep process:
step 1: a garbo hourly job that does a small amount of conversions. It needs to do at least 175 per garbo invocation if we want a 6 month completion date. I think that most bugs are small enough we could even set the minimum to 350 : the auto loop tuner will do more if more is acceptable given db load and time taken.
--- Done
step 2: start setting BugMessage.index when adding BugMessages - this will require calculating and setting the BugMessage.index for all other messages on the bug at the same time for consistency.
--- Done
step 3: when fully populated, make the bugmessage.index column NON-NULL, remove the garbo job to set bugmessage.index and remove the calculation of bugmessage.index for existing messages when adding a new message.
--- Done
step 4: We can fix bug 607935
Related branches
- Stuart Bishop (community): Approve
-
Diff: 285 lines (+100/-9)9 files modifieddatabase/schema/security.cfg (+1/-0)
lib/lp/bugs/configure.zcml (+2/-1)
lib/lp/bugs/interfaces/bug.py (+3/-0)
lib/lp/bugs/interfaces/bugmessage.py (+7/-0)
lib/lp/bugs/model/bug.py (+30/-6)
lib/lp/bugs/model/bugmessage.py (+4/-2)
lib/lp/bugs/tests/test_bug_messages.py (+5/-0)
lib/lp/scripts/garbo.py (+27/-0)
lib/lp/scripts/tests/test_garbo.py (+21/-0)
Changed in launchpad: | |
assignee: | nobody → Robert Collins (lifeless) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
status: | Fix Released → Triaged |
milestone: | 11.02 → none |
description: | updated |
tags: |
added: qa-ok removed: qa-untestable |
description: | updated |
description: | updated |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
description: | updated |
Fixed in stable r12289 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12289>.