Extra bytes at the beginning of the /chrome/pt-PT/locale/branding/brand.dtd file in Brazilian Portuguese

[David Planella]

While importing the Firefox translations in Ubuntu to be included in language packs, we noticed that there is an error in the Portuguese translation that prevents the import. Here is the error message in the Launchpad XPI checker:

chrome/pt-PT/locale/branding/brand.dtd: Illegal construct

This seems to do with some extra bytes (UTF-8 BOM mark) that appear at the beginning of the file, which can be seen with a hex editor.

It would be great if the Portuguese team could have a look at it, which would allow to import and ship the translation in Ubuntu. Thanks!

More details:
https://translations.launchpad.net/ubuntu/natty/+source/firefox/+imports

[David Planella (dpm)]

That looks like the UTF-8 BOM mark at the beginning of the file

[David Planella (dpm)]

While importing the Firefox translations in Ubuntu to be included in language packs, we noticed that there is an error in the Brazilian Portuguese translation that prevents the import. Here is the error message in the Launchpad XPI checker:

chrome/pt-PT/locale/branding/brand.dtd: Illegal construct

This seems to do with some extra bytes (UTF-8 BOM mark) that appear at the beginning of the file, which can be seen with a hex editor.

It would be great if the Brazilian Portuguese team could have a look at it, which would allow to import and ship the translation in Ubuntu. Thanks!

More details:
https://translations.launchpad.net/ubuntu/natty/+source/firefox/+imports

[David Planella (dpm)]

Btw, I meant to say the Portuguese team on the initial comment (pt-PT), not the Brazilian team (pt-BR), but it seems it got assigned to the right team anyway.

[João Ricardo Lourenço (jorl17)]

Greetings.

There seems to be a new uploaded version that does not have the initial extra bytes, uploaded by David Planella, correct? If that version is a simple "byte-removal-fix", can I assume that the issue is fixed?

[David Planella (dpm)]

El dj 20 de 01 de 2011 a les 15:07 +0000, en/na João Ricardo Lourenço va
escriure:
> Greetings.
>
> There seems to be a new uploaded version that does not have the initial
> extra bytes, uploaded by David Planella, correct? If that version is a
> simple "byte-removal-fix", can I assume that the issue is fixed?
>

I uploaded a file with a fix, which Tiago Hillebrandt created. We'll
have to wait until the file is imported to see if it suceeded.

If you could coordinate with upstream to fix it there, that'd be
awesome.

Thanks!

[João Neves (jneves)]

Is this still an issue? With which version? I'm not seeing that char in any of the brand.dtd files...

[L10n-mozilla (l10n-mozilla)]

That'd be on 1.9.2, same on l10n-central.

wokbok:~ axelhecht$ cd src/central/releases/l10n-mozilla-1.9.2/pt-PT/
wokbok:pt-PT axelhecht$ file other-licenses/branding/firefox/brand.dtd
other-licenses/branding/firefox/brand.dtd: UTF-8 Unicode (with BOM) text

[João Neves (jneves)]

Thanks a lot Axel. I was looking at the files not seeing it.

Corrected in changeset 557:98831c3ea194 for brand.dtd. I've found other files in the localization and will correct those next.

[João Neves (jneves)]

Ok, just pushed changesets in l10n-1.9.2 and l10n-central removing all Byte-Order-Markers.

It should be effective for the next versions of mozilla applications. David, sorry for the delay.

[David Planella (dpm)]

Thanks a lot for taking care of this, João!