don't moan about out-of-date plugins

[Martin Pool]

At the moment plugins specify the version of the bzrlib api that they need. If we can't satisfy the dependency, then we give a noisy warning and refuse to load it.

But this is in fact rather pedantic: many 2.3 plugins, even if not specifically tested with a later bzr version are still quite likely to work there.

So instead, for plugins that are out of date:

 * remember this
 * log it
 * print it in apport crashes
 * print it in non-apport crashes
 * print it in `bzr plugins`

Then if there is an actual problem, users will get a clue that the plugin is out of date. If there is no actual problem, we won't annoy them.

We can also add a test saying "there are no out-of-date plugins" and that will remind developers to update the check.

[Martin Pool (mbp)]

Loading plugins even if their requested api version isn't present is just a bit non-trivial, because currently that's signaled by raising an exception, so I'll handle that separately: bug 704238.

[Zearin (zearin)]

Don't know much about Python, but I do agree with the spirit of this “bug”. I’ve been getting plugin warnings for ages, and although I figured it wouldn't be a big deal, the fact that it was reminding me about the error repeatedly (not just when starting a bzr session) did make me think twice. I wondered if in fact it might be a bigger deal.

Seems like something that might still be worth reporting if using something like -verbose or some similar flag (-debug?).

[Martin Pool (mbp)]

On 19 January 2011 10:09, Zearin <email address hidden> wrote:
> Don't know much about Python, but I do agree with the spirit of this
> “bug”.  I’ve been getting plugin warnings for ages, and although I
> figured it wouldn't be a big deal, the fact that it was reminding me
> about the error repeatedly (not just when starting a bzr session) did
> make me think twice.  I wondered if in fact it might be a bigger deal.
>
> Seems like something that might still be worth reporting if using
> something like -verbose or some similar flag (-debug?).

It will still be in .bzr.log and `bzr plugins`.

--
Martin