Hugin contains a bundled tclap-1.2.0

[Bruno Postle]

src/foreign/tclap is a bundled version of tclap <http://tclap.sourceforge.net/> This is a problem with some Linux distributions such as Debian and fedora that have policies to not ship multiple versions of the same library.

The solution would be to modify the cmake configuration to allow building against a system version of this library, and/or to remove the bundled library altogether.

[Andreas Metzler (k-launchpad-downhill-at-eu-org)]

FWIW I have compared src/foreign/tclap with upstream releases. The copy in src/foreign is 1.1.0 (released 2006-08-19) + two one-line changes instead of the latest release 1.2.0 (2009-09-28).

[Andreas Metzler (k-launchpad-downhill-at-eu-org)]

works-for-me patch attached.

[tmodes (tmodes)]

Hi Andreas,
thanks for the patch. I commited a slightly modifiy version of your patch and extended it for windows. The bundled tclap could so removed.
Should this go into 2011.0?

[Yuv (yuv)]

Thanks for helping keeping the codebase lean and clean.

So far we have confirmation that this works for Linux and Windows. How about OSX?

For Windows: has the SDK documentation on the wiki been updated, or will builder experience a break?

[Bruno Postle (brunopostle)]

Thanks, please don't fix 2011.0. tclap isn't in fedora yet, I should be able to get it accepted by the time 2011.2.0 is released.

[Yuv (yuv)]

FindTclap.cmake is broken on Ubuntu. The automatic build from the Hugin PPA reports:

-- checking for module 'tclap>=1.1'
-- package 'tclap>=1.1' not found
CMake Error at CMakeLists.txt:274 (MESSAGE):
  Tclap library not found

for Lucid, Maverick, Natty.

[tmodes (tmodes)]

Wiki was updated after pushing to repository.

I have no experience with PPA. I added a more general FindTclap.cmake. Please test.

[Andreas Metzler (k-launchpad-downhill-at-eu-org)]

On 2011-03-07 Yuv <email address hidden> wrote:
> FindTclap.cmake is broken on Ubuntu. The automatic build from the Hugin
> PPA reports:

> -- checking for module 'tclap>=1.1'
> -- package 'tclap>=1.1' not found
> CMake Error at CMakeLists.txt:274 (MESSAGE):
> Tclap library not found

> for Lucid, Maverick, Natty.

Did you add a build-dependcy on libtclap-dev?
cu andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

[Yuv (yuv)]

On March 7, 2011 12:13:20 PM tmodes wrote:
> I have no experience with PPA.

The PPA is documented at http://wiki.panotools.org/Hugin_PPA in more detail
than a developer really need to know.

From a developer perspective it is a very simple concept: source packages are
uploaded to a clean automated build system. At
https://launchpad.net/~hugin/+archive/nightly the uploads are automatic as
well (nightlies). In case of success there is a new nightly to install/test.
In case of failure there is a failure log that can help debugging. As a
member of Hugin PPA I receive emails with links to the failed build logs.

You can see all build logs (more than 400 of them) at
https://launchpad.net/~hugin/+archive/nightly/+builds?build_text=&build_state=all

> I added a more general FindTclap.cmake.
> Please test.

The latest I received :(

http://launchpadlibrarian.net/66165728/buildlog_ubuntu-maverick-
i386.hugin_2010.5.0%2B2011.0.0%2Bhg5099-0ubuntu1~maverick_FAILEDTOBUILD.txt.gz

I'm setting up a build environment on my Natty netbook now and will try the
attached FindTclap.cmake later.

Yuv

 status new

[Yuv (yuv)]

Hugin from Mercurial built perfectly on Natty, no need for the more general FindTclap.cmake on this machine. Will have to test it again on the Lucid workstation but I don't have access to it now. The PPA problems are probably due to the lack of dependency as Andreas pointed out. I do not have access to fix the script that automates the nightlies PPA. I will try a manually built source package later this weekend when releasing beta3 and will report back.

[Yuv (yuv)]

Confirm: the FindTclap.make attached to comment #7 fixes the CMake build in Lucid. Please commit.

[DinoTools (oss-dinotools-de)]

Sorry for the delay on the Nightly Build PPA. I have fixed the build dependencies.