[ctrl-a] sometimes makes attributes move too far

[KaiMartin]

In git head, there is a new feature to select all with [ctrl-a].
Under specific circumstances, visible attributes move at double pace
compared to the rest of the symbol. To reproduce:

1) open a new schematic

2) choose two arbitrary symbols and place them about 10 cm above each
other on the canvas

3) select both symbols

4) move the selection such that one of the symbols is below the lower
border of the canvas (not the view port)

5) click somewhere else to unselect the symbols

6) select all with [ctrl-a]

7) move the selection

The visible attributes will move correctly during movement but will
jump ahead when the move is done.

---<)kaimartin(>---

[Krzysztof Kościuszkiewicz (k-kosciuszkiewicz)]

The bug occurs with all commands executed after executing the action edit-select-all.
For example move-copy copies the attached attributes twice.
Move moves the attributes twice (distance moved is doubled).
In the console the following messages can be seen:
  object already selected == TRUE
This suggests the attributes are added to the selection list twice.

[Krzysztof Kościuszkiewicz (k-kosciuszkiewicz)]

Proposed fix in libgeda - check if object is already selected to avoid double selection.

[Peter Clifton (pcjc2)]

Good catch. I'll assign Peter B to commit this, as I'm busy right now.