HTML code for Comment scores is escaped in report card pdf
Bug #702918 reported by
Douglas Cerna
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| SchoolTool Gradebook |
Fix Released
|
Undecided
|
Douglas Cerna | ||
Bug Description
I deployed an activity with a Comment scoresystem, graded the activity using the fck editor using rich text, set up the report card layout and and when I generated the report card, a <strong></strong> tag was in the PDF (see attachment).
Related branches
lp:~replaceafill/schooltool.gradebook/replaceafill_schooltool.gradebook
- SchoolTool Owners: Pending requested
-
Diff: 8248 lines (+5164/-785)49 files modifiedCHANGES.txt (+4/-0)
src/schooltool/gradebook/activity.py (+15/-6)
src/schooltool/gradebook/browser/activity.py (+129/-92)
src/schooltool/gradebook/browser/configure.zcml (+47/-43)
src/schooltool/gradebook/browser/ftesting.zcml (+76/-10)
src/schooltool/gradebook/browser/ftests/activity_categories.txt (+36/-5)
src/schooltool/gradebook/browser/ftests/activity_dates.txt (+88/-0)
src/schooltool/gradebook/browser/ftests/category_weighting.txt (+103/-18)
src/schooltool/gradebook/browser/ftests/column_linking.txt (+262/-30)
src/schooltool/gradebook/browser/ftests/due_date_filter.txt (+464/-0)
src/schooltool/gradebook/browser/ftests/export.txt (+12/-14)
src/schooltool/gradebook/browser/ftests/external_activities.txt (+32/-19)
src/schooltool/gradebook/browser/ftests/gradebook_management.txt (+126/-27)
src/schooltool/gradebook/browser/ftests/last_visited_section.txt (+8/-8)
src/schooltool/gradebook/browser/ftests/mygrades.txt (+2/-2)
src/schooltool/gradebook/browser/ftests/report_card.txt (+88/-87)
src/schooltool/gradebook/browser/ftests/report_sheets.txt (+699/-0)
src/schooltool/gradebook/browser/ftests/request_reports.txt (+51/-25)
src/schooltool/gradebook/browser/ftests/rml_gradebook.txt (+295/-0)
src/schooltool/gradebook/browser/ftests/rml_student.txt (+2214/-0)
src/schooltool/gradebook/browser/ftests/sections_without_course.txt (+25/-6)
src/schooltool/gradebook/browser/ftests/security.txt (+2/-2)
src/schooltool/gradebook/browser/ftests/worksheet_hiding.txt (+2/-2)
src/schooltool/gradebook/browser/ftests/worksheet_preferences.txt (+101/-11)
src/schooltool/gradebook/browser/gradebook.py (+32/-19)
src/schooltool/gradebook/browser/pdf_views.py (+37/-22)
src/schooltool/gradebook/browser/report_card.py (+26/-24)
src/schooltool/gradebook/browser/request_reports.py (+2/-2)
src/schooltool/gradebook/browser/resources/gradebook.css (+3/-0)
src/schooltool/gradebook/browser/resources/gradebook_overview.js (+0/-34)
src/schooltool/gradebook/browser/rml/report_card_rml.pt (+1/-1)
src/schooltool/gradebook/browser/templates/add_edit_linked_column.pt (+5/-4)
src/schooltool/gradebook/browser/templates/gradebook_overview.pt (+76/-91)
src/schooltool/gradebook/browser/templates/layout_report_card.pt (+1/-1)
src/schooltool/gradebook/browser/templates/linkedactivity_add.pt (+0/-60)
src/schooltool/gradebook/browser/templates/linkedactivity_edit.pt (+0/-60)
src/schooltool/gradebook/browser/templates/report_worksheet_overview.pt (+2/-2)
src/schooltool/gradebook/browser/templates/request_student_report.pt (+1/-1)
src/schooltool/gradebook/browser/templates/weight_categories.pt (+1/-1)
src/schooltool/gradebook/browser/tests/test_pdf_views.py (+44/-31)
src/schooltool/gradebook/browser/worksheet.py (+14/-16)
src/schooltool/gradebook/generations/tests/__init__.py (+6/-1)
src/schooltool/gradebook/generations/tests/test_evolve1.py (+2/-0)
src/schooltool/gradebook/generations/tests/test_evolve2.py (+2/-0)
src/schooltool/gradebook/gradebook.py (+6/-2)
src/schooltool/gradebook/interfaces.py (+1/-4)
src/schooltool/gradebook/tests/stubs.py (+11/-1)
src/schooltool/gradebook/tests/test_gradebook.py (+4/-1)
src/schooltool/requirement/browser/scoresystem_add.pt (+6/-0)
Revision history for this message
| Douglas Cerna (replaceafill) wrote | #1 |
Revision history for this message
| Douglas Cerna (replaceafill) wrote | #2 |
| Changed in schooltool.gradebook: | |
| assignee: | nobody → Douglas Cerna (replaceafill) |
| summary: |
- HTML code for Comment scores is not escaped in report card + HTML code for Comment scores is escaped in report card pdf |
| Changed in schooltool.gradebook: | |
| status: | New → Fix Committed |
| Changed in schooltool.gradebook: | |
| milestone: | none → 0.9.0 |
| Changed in schooltool.gradebook: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Even though the <strong>, <b>, <em> and <i> tags are valid in Reportlab, the rml template (schooltool/