Can't delete branches from the API that can be deleted from the web UI
Bug #702620 reported by
James Westby
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
j.c.sackett |
Bug Description
Hi,
There are branches that can be delete from the web UI that can't be deleted over the API.
This is because those branches have artefacts that are presented when deleting and you
can choose to proceed, but the destructor for the branch refuses to delete when you do this.
It is possible to manually delete all artefacts first, but that's a headache.
It should be possible to delete something easily, while still being "safe".
Attempts to use the destructor show up as OOPS-1839N1575
Related branches
lp:~jcsackett/launchpad/branch-delete-api-702620
- Leonard Richardson (community): Approve
-
Diff: 136 lines (+72/-8)4 files modifiedlib/lp/code/errors.py (+3/-0)
lib/lp/code/model/branch.py (+7/-1)
lib/lp/code/tests/test_branch.py (+1/-7)
lib/lp/code/tests/test_branch_webservice.py (+61/-0)
tags: | added: code-integration |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: api |
description: | updated |
tags: | added: oops |
Changed in launchpad: | |
importance: | High → Critical |
Changed in launchpad: | |
assignee: | nobody → j.c.sackett (jcsackett) |
Changed in launchpad: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Per a discussion with other developers, not having a branch delete over the webservice delete the involved artifacts was a conscious decision in the creation of the method.
That said, this method shouldn't return a 500, as shown in the OOPS.