"bzr version-info --python" does not give pep-8 compliant output

[Soren Hansen]

$ bzr version-info --python > version_info.py ; pep8 --show-pep8 --show-source version_info.py
version_info.py:20:1: E303 too many blank lines (3)
if __name__ == '__main__':
^
    Separate top-level function and class definitions with two blank lines.

    Method definitions inside a class are separated by a single blank line.

    Extra blank lines may be used (sparingly) to separate groups of related
    functions. Blank lines may be omitted between a bunch of related
    one-liners (e.g. a set of dummy implementations).

    Use blank lines in functions, sparingly, to indicate logical sections.

    Okay: def a():\n pass\n\n\ndef b():\n pass
    Okay: def a():\n pass\n\n\n# Foo\n# Bar\n\ndef b():\n pass

    E301: class Foo:\n b = 0\n def bar():\n pass
    E302: def a():\n pass\n\ndef b(n):\n pass
    E303: def a():\n pass\n\n\n\ndef b(n):\n pass
    E303: def a():\n\n\n\n pass
    E304: @decorator\n\ndef a():\n pass

[Martin Pool (mbp)]

As a follow on, it might be nice to make bzr's test_source run pep8
checks if the tools to do so are available. That would be better than
recreating some of them by hand.

--
Martin

[Soren Hansen (soren)]

Ah, conditionally using pep8 is a good idea. I wanted to use pep8 to begin with, but didn't want to add a dependency on it.

[Soren Hansen (soren)]

I just took a stab at this, but pep8.py seems to not be designed for this sort of use. At all.

[Martin Pool (mbp)]

On 19 January 2011 18:28, Soren Hansen <email address hidden> wrote:
> I just took a stab at this, but pep8.py seems to not be designed for
> this sort of use. At all.

It would be fine if you run it as a subprocess, if it can't be used inprocess.

--
Martin