Files Utility: crash when Create Folder with special characters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mira Groupware |
New
|
High
|
Unassigned |
Bug Description
I was testing the Create Folder tool in the Files Utility of the default Workplace: Mira.
I tried entering some special characters into the folder names to see how the application would handle them. Most special characters are accepted - even characters that are not ordinarily accepted in folder names on Linux and Windows. However, I think the forward slash / caused a crash. Please find below the console output for Mira Client and Mira Server, both built from rev. 259 of the login-system branch.
Client log:
=============
OUT: UT "Files" "Mira" C "w@w"
bytes_transferred: 25
IN: UT Files Mira C FO "w@w"
utility_name: Files
workplace_name: Mira
adding to buffer...
OUT: UT "Files" "Mira" C ""-/"
bytes_transferred: 48
IN: UT Files Mira E C ""-/"No such (virtual) folder
utility_name: Files
workplace_name: Mira
Illegal instruction
=============
Server log:
=============
IN: UT "Files" "Mira" C "w@w"
OUT: UT Files Mira C FO "w@w"
OUT: UT Files Mira FC FO "w@w" "Max Bossino"
OUT: UT Files Mira FC FO "w@w" "Max Bossino"
bytes_transferred: 26
IN: UT "Files" "Mira" C ""-/"
OUT: UT Files Mira E C ""-/"No such (virtual) folder
Segmentation fault
=============
I presume this is because there is no input validation by the tool. This probably applies to the Upload File tool as well, in that it does not validate filenames to remove illegal characters.
It would be best to offer some input validation functions to be used throughout Mira, especially in tools such as Create Folder and Upload File to prevent this type of problem.