Patch to update settings-tester.pl -- not a bug... perhaps an imrovement...

Bug #701230 reported by Robert Soulliere
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen version: trunk

This is a patch to update settings-tester.pl in the support-scripts folder.

Changes include:

- Use Test::More perl module to replace eval/die tests for initial tests (as indicated in FIXME comment)
Note/question: should I add an install of the Test::More perl module in Makefile.install for Evergreen prerequisites?

- Add a statement to print postgresql version.

- Add an elsif during "driver" testing to say OK to SIP driver since this is used in telephony section. -- remove scary ERROR

- Add UUID::Tiny to perl module list of checks.
question: More perl module checks needed?

Please provide feedback on if this is an improvement or if there are any other areas we should improve in this settings tester. eg.: potential new tests or removal of outdated tests.

Future tasks:
Should try to do more version checking to ensure correct versions of some problematic perl modules are correct.

Revision history for this message
Robert Soulliere (rcsoulliere) wrote :
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
Jason Stephenson (jstephenson) wrote :

After applying this patch to a trunk version of settings-tester.pl, the following error message is reported:

Useless use of a variable in void context at (eval 1110) line 2.

The error message doesn't appear with an unpatched settings-tester.pl.

I'm not sure what version of Evergreen this patch is targeted at, so I tried on the server that I've been doing the most work on lately.

Revision history for this message
Robert Soulliere (rcsoulliere) wrote :

Another try...

Addressed the error message.
Added a few more perlmods to test.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

The newer patch looks good to me.

I see this works on both trunk and 2.0 as there are currently no differences between the two.

Should this be targeted for a milestone?

Revision history for this message
Mike Rylander (mrylander) wrote :

Committed to trunk. Thanks, Robert!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.