Undefined funciton read-expression in vm-serial.el

[Tim Cross]

Compiling latest code gives a warning about a possibly undefined function in vm-serial.el, read-expression.

Looking at the code, vm-serial-set-token appears to call this function in a let*

Earlier in the code, this comment is listed

;; The following function is erroneously called in fsfemacs too
;; (declare-function read-expression "vm-xemacs"
;; (prompt &optional initial-contents history default))

There does not appear to be anything in vm-serial-set-token or vm-serial-set-tokens that would ensure that vm-serial-set-token is only called when running under xemacs or any alternative execution path for fsfemacs. The function read-expression does not exist in fsfemacs v24

[Uday Reddy (reddyuday)]

Hi Tim, as you know I am not maintaining any of Rob's add-ons. If you
can find the the FSF equivalent of the function, please feel free to
fix it. There might be need to condition the whole of vm-serial.el
for FSF and XEmacs.

Cheers,
Uday

[Tim Cross (tcross)]

On Tue, Jan 11, 2011 at 1:07 AM, Uday Reddy <email address hidden> wrote:

> Hi Tim, as you know I am not maintaining any of Rob's add-ons. If you
> can find the the FSF equivalent of the function, please feel free to
> fix it. There might be need to condition the whole of vm-serial.el
> for FSF and XEmacs.
>
> Cheers,
> Uday
>
> My mistake - forgot that was an add-on and not a core part.

Tim

[Tim Cross (tcross)]

Changed this one to a wishlist item as it represents a bug in the unsupported non-core add-on code. Figure may as well keep it listed as it could be useful when we do get around to addressing some of this stuff.