Dirty tracks cause incorrect sorting and searching

[Owen Williams]

If I make changes to track metadata (retitling, or changing the comment, etc), subsequent searches of the library don't reflect the new values. This is because the search function only uses the database, not the dirty track data.

The fix for this bug is either:
* rewrite the search function to look through the dirty tracks (hard coding but fast execution)
* save dirty tracks before performing the search (easy coding but whacks the DB)

[RJ Skerry-Ryan (rryan)]

Fixing searching and sorting to defer to the track cache is pretty hard given the way things work now sadly. Correctness has a pretty big cost in this case. Every single track gets dirtied now on load b/c it is marked played, so on a sort or search we have to save ~50 tracks if the cache is full.

[Owen Williams (ywwg)]

In my own tree I created a timer to automatically save dirty tracks every 5 minutes, and also save dirty tracks when each search is performed. I haven't noticed any performance problems as a result, but I'm on a fairly modern system.

Is the alternative to add code to perform searches within the dirty tracks? I guess that's a pain, although not undoable.

[RJ Skerry-Ryan (rryan)]

When you save the dirty tracks though, the information in the library table becomes stale right?

[Owen Williams (ywwg)]

What do you mean by stale? Like, the library table is out of date vs the database? I haven't noticed the table ever being out of date. Like, say, when I load in a new track, the bpm and comment field still auto-fill, so that seems to work.

[RJ Skerry-Ryan (rryan)]

Example :

1) Play songs, their played checkbox is checked.
2) Track save timer fires
3) Now that the tracks are no longer in the track cache, their checkboxes disappear.
4) Hit a column header to sort, the track details are back up to date.

B/c the table caches the entire query result set, once a track goes out of the track cache, the old, stale query cache is used, which results in the data for the track showing in the table being stale.

[Owen Williams (ywwg)]

You're right I think I've seen this happen.

[RJ Skerry-Ryan (rryan)]

Pushed a fix to 1.9.x. Changes should be in trunk soon.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5750