[6.0 rc2] test fails in module document_ftp

[Bogdan Stanciu]

during setup, the following test fails:

[2011-01-09 12:31:03,482][bs_test03_fr] INFO:init:module document_ftp: loading test/document_ftp_test2.yml
[2011-01-09 12:31:03,577][?] INFO:FTP:[]127.0.0.1:57058 Connected.
[2011-01-09 12:31:03,578][?] INFO:FTP:[]@127.0.0.1:57058 Disconnected.
[2011-01-09 12:31:03,579][?] INFO:FTP:[]127.0.0.1:57059 Connected.
[2011-01-09 12:31:03,608][?] INFO:FTP:[admin]@127.0.0.1:57059 User admin logged in.
[2011-01-09 12:31:06,354][bs_test03_fr] INFO:FTP:[admin]@127.0.0.1:57059 FAIL get_crdata() "/bs_test03_fr" errno=2: Authentification Required..
[2011-01-09 12:31:06,355][bs_test03_fr] ERROR:tests.document_ftp:550 Authentification Required..
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 729, in process
    self._process_node(node)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 744, in _process_node
    self.process_python(node)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 414, in process_python
    unsafe_eval(code_obj, {'ref': self.get_id}, code_context)
  File "/home/openerp/addons/document_ftp/test/document_ftp_test2.yml", line 2, in <module>
    In order to test the document_ftp functionality
  File "/home/openerp/addons/document_ftp/test_easyftp.py", line 41, in get_ftp_login
    ftp.cwd("/" + cr.dbname)
  File "/usr/lib/python2.6/ftplib.py", line 541, in cwd
    return self.voidcmd(cmd)
  File "/usr/lib/python2.6/ftplib.py", line 248, in voidcmd
    return self.voidresp()
  File "/usr/lib/python2.6/ftplib.py", line 223, in voidresp
    resp = self.getresp()
  File "/usr/lib/python2.6/ftplib.py", line 218, in getresp
    raise error_perm, resp
error_perm: 550 Authentification Required..
[2011-01-09 12:31:06,376][bs_test03_fr] ERROR:test:Tests failed to execute in module document_ftp
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/__init__.py", line 672, in load_test
    _load_data(cr, module_name, id_map, mode, 'test')
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/__init__.py", line 695, in _load_data
    tools.convert_yaml_import(cr, module_name, file, id_map, mode, noupdate)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 794, in yaml_import
    yaml_interpreter.process(yaml_string)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 729, in process
    self._process_node(node)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 744, in _process_node
    self.process_python(node)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/yaml_import.py", line 414, in process_python
    unsafe_eval(code_obj, {'ref': self.get_id}, code_context)
  File "/home/openerp/addons/document_ftp/test/document_ftp_test2.yml", line 2, in <module>
    In order to test the document_ftp functionality
  File "/home/openerp/addons/document_ftp/test_easyftp.py", line 41, in get_ftp_login
    ftp.cwd("/" + cr.dbname)
  File "/usr/lib/python2.6/ftplib.py", line 541, in cwd
    return self.voidcmd(cmd)
  File "/usr/lib/python2.6/ftplib.py", line 248, in voidcmd
    return self.voidresp()
  File "/usr/lib/python2.6/ftplib.py", line 223, in voidresp
    resp = self.getresp()
  File "/usr/lib/python2.6/ftplib.py", line 218, in getresp
    raise error_perm, resp
error_perm: 550 Authentification Required..
[2011-01-09 12:31:06,383][bs_test03_fr] INFO:FTP:[admin]@127.0.0.1:57059 Disconnected.

[Vo Minh Thu (thu)]

A failed test at installation time doesn't prevent the rest of the process to be done correctly.

The reason you have this problem is probably caused by providing a different password than 'admin' for the user 'admin'. The document_ftp test assumes the password is the same as the login (in the general case, where passwords are possibly hashed in db, the test has no knowledge of the password).

The test runs correctly for our build bot.

[Bogdan Stanciu (bstanciu)]

On 10. 01. 11 10:27, Vo Minh Thu wrote:
> A failed test at installation time doesn't prevent the rest of the
> process to be done correctly.
>
> The reason you have this problem is probably caused by providing a
> different password than 'admin' for the user 'admin'. The document_ftp
> test assumes the password is the same as the login (in the general case,
> where passwords are possibly hashed in db, the test has no knowledge of
> the password).
>
> The test runs correctly for our build bot.
>
thank you!

i will check that and let you know. however, in mho, the test should be
able to check the password at some moment...

b

[xrg (xrg)]

On Monday 10 January 2011, you wrote:
> On 10. 01. 11 10:27, Vo Minh Thu wrote:
> > A failed test at installation time doesn't prevent the rest of the
> > process to be done correctly.
> >
> > The reason you have this problem is probably caused by providing a
> > different password than 'admin' for the user 'admin'. The document_ftp
> > test assumes the password is the same as the login (in the general case,
> > where passwords are possibly hashed in db, the test has no knowledge of
> > the password).
> >
> > The test runs correctly for our build bot.
>
> thank you!
>
> i will check that and let you know. however, in mho, the test should be
> able to check the password at some moment...
>

Well, the right solution is at the "trunk-xrg" branch, in git. That patch
never made it to trunk, though :(

[tfr (Openerp) (tfr)]

@XRG, if you've got the patch, can you please submit it as a merge proposal in launchpad ?

[xrg (xrg)]

On Tuesday 11 January 2011, you wrote:
> @XRG, if you've got the patch, can you please submit it as a merge
> proposal in launchpad ?

lp:~xrg/openobject-addons/trunk-patch20

[Bhumika Shrimali (sbh-openerp)]

Hello,

The fix has been committed to lp:~openerp-dev/openobject-addons/trunk-dev-addons1
 Soon, it will be merged into trunk-addons.

Thanks