Ratings don't show on any tracks
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
CoverGloobus |
Fix Committed
|
Low
|
Alexandr Grigorcea |
Bug Description
Using the Guayadeque player all tracks show 0 stars, even when they're rated higher. I checked to make sure that Guayadeque does, in fact, pass the rating info in it's track metadata. It passes a score from 1 to 5, and if the track has no rating (a score of 0), then no rating info is passed.
It looks like the base MPRIS class doesn't even bother copying the info from the rating key to the track info. So this would effect any and all players that work off the MPRIS base class unless they have their own get_track function (like Rythmbox does). Should there be a 'try: track.rating = data['rating']' in the MPRIS base class, or does the implementation of rating data change from player to player? I can verify that adding it to the Guayadeque file will make it work for all tracks (see attachment).
Thanks, Mackenan.
Actually this affects all MPRIS players.
rating metadata is in MPRIS specifications so I've added rating reading to MPRIS plugin