widelands

textarea not redrawn when it should be updated

Bug #700389 reported by Hans Joachim Desserud on 2011-01-08

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	widelands	Fix Released	High	Nicolai Hähnle	widelands build16-rc1

Bug Description

Below is the original bug report, but this bug appears on other places as well (e.g. the chat window is not updated (and scrolled down to the end), if a new message was send or received)) - properly a bug based on the ui caching changes
_________________________________

Trainingsites will show the stats of an individual soldier if you hover the cursor over that soldier. However, if you move the cursor directly from one soldier to another, the stats is not updated, even if the new soldier has different stats.

Steps to reproduce:
1. Open a trainingsite. (make sure some of the soldiers are more trained than others.)
2. Place the cursor over one soldier.
3. Observe the stats for the current selected soldier is correct.
4. Move the cursor directly to another soldier with other stats.

Actual result: the stats are not updated.
Expected: the stats of the currently selected soldier is shown. Note that if you move the cursor away from all the soldiers, before moving it back, the correct stats are displayed. In effect only the stats of the first selected soldier is shown.
I think this is likely a regression, like bug 695016.

Widelands r5800 on Ubuntu 10.10.

See original description

Tags:

Revision history for this message

Hans Joachim Desserud (hjd) wrote on 2011-01-08:

The stats shown clearly does not belong the the soldier where the cursor is placed Edit (75.5 KiB, image/png)

tags:

added: soldiers ui

Revision history for this message

Nasenbaer (nasenbaer) wrote on 2011-01-17:

I can confirm this bug and changed it to a more general one, as this bug appears on otherp laces as well, e.g.:

the chat window is not redrawn, when updated.

Changed in widelands:
milestone:	none → build16-rc1
importance:	Undecided → High
status:	New → Confirmed
description:	updated
tags:	added: cache textarea
summary:	- Stats does not update when moving cursor from soldier to soldier in - trainingsites + textarea not redrawn when it should be updated

Revision history for this message

Nasenbaer (nasenbaer) wrote on 2011-01-19:

likely connected to bug #695016

Nicolai Hähnle (nha) on 2011-01-24

Changed in widelands:
assignee:	nobody → Nicolai Hähnle (nha)

Nicolai Hähnle (nha) on 2011-01-30

Changed in widelands:
status:	Confirmed → Fix Committed

Revision history for this message

Nicolai Hähnle (nha) wrote on 2011-01-30:

The originally reported bug is fixed in trunk.

The chat bug is genuinely different, because its root cause lies in the awkward and messy implementation of Multiline_Textarea. This cannot be fixed easily (except by an ugly hack like deactivating the caching), as it basically requires the ability to compute the total height of richtext content without rendering that content.

Refactoring that richtext renderer is the next big item on my list, as it is also required to fix image rendering in OpenGL mode properly.

Revision history for this message

SirVer (sirver) wrote on 2011-04-04:

Released in build16-rc1