solder mask drawing glitch in pcb
Bug #699498 reported by
rdrehmel
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pcb |
Fix Released
|
Medium
|
Unassigned |
Bug Description
The attached patch fixes drawing of solder mask above pads.
In the case of having a pad with a solder mask value of 0
(i.e. completely covered by solder mask), the drawing code which
clears the solder mask from the pad should not be run. This
not only saves a few cycles (probably irrelevant), but more importantly
fixes the one-pixel lines of removed solder-mask, which can occur
when Pad->Mask is 0.
Changed in pcb: | |
status: | New → Confirmed |
Changed in pcb: | |
assignee: | nobody → DJ Delorie (dj-delorie) |
Changed in pcb: | |
assignee: | DJ Delorie (djdelorie) → Peter Clifton (pcjc2) |
Changed in pcb: | |
milestone: | future-bug-release → next-bug-release |
Changed in pcb: | |
status: | Fix Committed → Fix Released |
status: | Fix Released → Fix Committed |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think it would be better to not call ClearPad() at all if pad->Mask is 0. The "true" parameter selects the mask or copper clearance size, not whether or not it draws.