Vertical panning with 'C' buggy

[richardneill]

If I have a large PCB, and have zoomed in, I can pan around by moving the mouse and pressing 'C'. The PCB then jumps to center the cursor.

For a blank board, this works perfectly, both horizontally and vertically.

For a board with some components, C works fine for horizontal centering, but does NOT work for vertical centering.

Tested with current release, and with latest git.

[DJ Delorie (djdelorie)]

Confirmed. GTK hid bug, lesstif hid works OK

[Ineiev (ineiev)]

This seems to fix it:
diff --git a/src/hid/gtk/gtkhid-main.c b/src/hid/gtk/gtkhid-main.c
index 7d59672..68f843e 100644
--- a/src/hid/gtk/gtkhid-main.c
+++ b/src/hid/gtk/gtkhid-main.c
@@ -91,8 +91,10 @@ ghid_pan_fixup ()
        return;
      }

+ ghidgui->adjustment_changed_holdoff = TRUE;
    gtk_range_set_value (GTK_RANGE (ghidgui->h_range), gport->view_x0);
    gtk_range_set_value (GTK_RANGE (ghidgui->v_range), gport->view_y0);
+ ghidgui->adjustment_changed_holdoff = FALSE;

    ghid_invalidate_all ();

Cheers,
Ineiev

[Felix Ruoff (felixruoff)]

This issue is fixed with commit d6dd08b4e0c1257994de834f07f194f1855c1606 by Peter Clifton on 27 Dec 2010 I think.