gschem: place the netname attribute at a decent distance

Bug #698800 reported by KaiMartin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Wishlist
Peter TB Brett

Bug Description

Currently, the letters of a new netname attribute touch the corresponding net. Please place the attribute at a decent distance (e.g. 50 units offset).
---<(kaimartin)>---

Changed in geda:
assignee: nobody → Edward Hennessy (ehennes)
status: New → Fix Committed
Revision history for this message
Patrick Bernaud (patrickb) wrote :

Note that it could have been done using a hook and the existing auto-place.

Revision history for this message
Edward Hennessy (ehennes) wrote :

Yes, it could. But, it seems reasonable for the application to position new attributes, then allow any hooks, if present, to re-position the attributes. I'm not against someone with more scheme experience moving this functionality into a hook.

Revision history for this message
Patrick Bernaud (patrickb) wrote :

My point was that it is doubling the amount of code for a single feature in addition to changing to the current behaviour.

There are already a few hooks defined in the default system-gschemrc that are making use of auto-place. Besides, the placement can be configured and the hook can be disabled by the user.

Revision history for this message
Peter TB Brett (peter-b) wrote :

Hi Ed -- please add a link to the commit that fixes this bug...!

Revision history for this message
Edward Hennessy (ehennes) wrote :
Revision history for this message
Peter TB Brett (peter-b) wrote :

Assigning this to me to replace with Scheme / hooks implementation.

Changed in geda:
assignee: Edward Hennessy (ehennes) → Peter TB Brett (peter-b)
Revision history for this message
Peter TB Brett (peter-b) wrote :

I've committed a version of Patrick's patch.

Changed in geda:
milestone: none → 1.9.1
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 9fb2513621a4e090dd0fdb7579249b94e62cc8e4
http://git.geda-project.org/geda-gaf/commit/?id=9fb2513621a4e090dd0fdb7579249b94e62cc8e4

commit 9fb2513621a4e090dd0fdb7579249b94e62cc8e4
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Autoplace netname attributes when they are initially added.

    Extension originally written by Patrick Bernaud, with minor changes by
    Peter Brett.

    Closes-bug: lp-698800

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.