tragesym extentions and code refactoring

Bug #698686 reported by werner2101
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Confirmed
Wishlist
Werner Hoch

Bug Description

Tamas Tszabo posted that version of tragesym on the gEDA-user mailing list.
I'm adding it here so that it doesn't get lost.

His changes are against version 0.0.11 of tragesym:
    * lot's off new options
    * code refactoring of the former writesym function
    * change of graphical attributes and locations of the pin attributs
    * changes of grahical attributes of the symbol attributs

Note: The whitespace changes and variable name changes will make it hard to merge this changes back to the master repo

The attached patch is against SHA1 925655e77c557504f9640cc98d59 in the stable-1.2 branch and has been created with the command:
git-diff-tree -p 0174a5b7fd726e3a10a73d81e731b 925655e77c557504f9640cc98d59 >tamas-tsabo_tragesym.diff

It contains the modified tragesym and two of his examples.

Regards
Werner

Tags: sf-patches
Revision history for this message
werner2101 (werner2101) wrote :
Peter TB Brett (peter-b)
Changed in geda:
assignee: nobody → Werner Hoch (werner-ho)
Revision history for this message
chrysn (chrysn) wrote :

please update the status of this bug. as long as it is unclear which version of tragesym is going to be utilized, some bug reports (which i was just about to open and to write pateches for) would be either moot or implemented differently.

the course of action i'd suggest on this is to declare the patch as rejected, but to flesh out the actual enhancements at least into dedicated bug reports, so that they can be individually worked on.

afaict, those would be:

* clean up whitespace (there's tabs and spaces in there...)
* new options (eg. hiding / dropping pin numbers)
* option name changes for clarity (personally, i'd drop that unless it can be done in a compatible fashion)

(note to self: this was about making tragesym more usable for creating hierarchic symbols, ie. dropping/hiding pin numbers and not complaining about presence of the source= attribute and the absence of others).

Revision history for this message
Werner Hoch (werner-ho) wrote :

Diff has not be applied, as it is a major change and hard to apply. Updated Bug status

Changed in geda:
importance: Undecided → Wishlist
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.