Bug #6976 “dh_gconf: postinst fragment crashes if gconfd-2 is no... : Bugs : debhelper package : Ubuntu

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2004-07-08:

#1

Automatically imported from Debian bug report #258281 http://bugs.debian.org/258281

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2004-07-08:

#2

Message-Id: <email address hidden>
Date: Thu, 08 Jul 2004 10:25:40 -0700
From: Zack Weinberg <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: dh_gconf: postinst fragment crashes if gconfd-2 is not running

Package: debhelper
Version: 4.2.12
Severity: grave
File: /usr/bin/dh_gconf
Justification: renders packages uninstallable

dh_gconf generates postinst fragments that contain the line

kill -HUP `pidof gconfd-2`

If gconfd-2 is not running when the postinst executes, this command
will fail, causing the postinst to abort. Suggest instead the construct

if gconfd_pid=`pidof gconfd-2`; then
kill -HUP $gconfd_pid
fi

(tested to work correctly when gconfd is not running, using both bash
and dash.) I'm calling this a grave bug because it renders packages
uninstallable, albeit not the debhelper package.

I encountered this problem with the gnome-session package; it should be
fixed quickly before the bad code propagates to more packages.

-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7
Locale: LANG=en_US, LC_CTYPE=en_US

Versions of packages debhelper depends on:
ii binutils 2.14.90.0.7-8 The GNU assembler, linker and bina
ii coreutils [fileutils] 5.0.91-2 The GNU core utilities
ii debconf-utils 1.4.29 debconf utilities
ii dpkg-dev 1.10.22 Package building tools for Debian
ii file 4.09-1 Determines file type using "magic"
ii html2text 1.3.2a-1 An advanced HTML to text converter
ii perl 5.8.4-2 Larry Wall's Practical Extraction
ii po-debconf 0.8.12 Manage translated Debconf template

-- no debconf information

Revision history for this message

In Debian Bug tracker #258281, Joey Hess (joeyh) wrote on 2004-07-08: Re: Bug#258281: dh_gconf: postinst fragment crashes if gconfd-2 is not running

#3

Zack Weinberg wrote:
> Package: debhelper
> Version: 4.2.12
> Severity: grave
> File: /usr/bin/dh_gconf
> Justification: renders packages uninstallable
>
> dh_gconf generates postinst fragments that contain the line
>
> kill -HUP `pidof gconfd-2`

No it doesn't.

joey@dragon:/usr/share/debhelper/autoscripts>grep gconfd-2 * /usr/bin/dh_gconf
zsh: exit 1 grep gconfd-2 * /usr/bin/dh_gconf

Two days ago, Josselin Mouette mailed me a new version of dh_gconf that
behaves as you describe, but I never uploaded a version of debhelper with
it (because Josselin did not send it as a patch or describe the changes,
and I did not yet have enough time to look over it and figure out what
he changed). Today he sent me a new version which seems to avoid that
problem. It had a few problems which I've fixed (a bashism) and I'm planning
to release debhelper with the attached patch tomorrow if Josselin confirms
it works.

Anyway, I don't know what version of debhelper or dh_gconf you're using, but
it's not one in the archive, and so I close this bug.

--
see shy jo

Revision history for this message

In Debian Bug tracker #258281, Zack Weinberg (zack-codesourcery) wrote on 2004-07-08:

#4

Joey Hess <email address hidden> writes:

>> dh_gconf generates postinst fragments that contain the line
>>
>> kill -HUP `pidof gconfd-2`
>
> No it doesn't.
>
> joey@dragon:/usr/share/debhelper/autoscripts>grep gconfd-2 * /usr/bin/dh_gconf
> zsh: exit 1 grep gconfd-2 * /usr/bin/dh_gconf

Sorry. I should have checked a little more carefully. I took the
contents of /var/lib/dpkg/info/gnome-session.postinst at face value.
It seems that the buggy version of dh_gconf was used to generate that
file; can I suggest you reassign the bug to gnome-session instead of
closing it?

zw

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2004-07-08:

#5

Download full text (6.2 KiB)

Message-ID: <email address hidden>
Date: Thu, 8 Jul 2004 16:15:32 -0400
From: Joey Hess <email address hidden>
To: Zack Weinberg <email address hidden>,
<email address hidden>
Cc: Josselin Mouette <email address hidden>
Subject: Re: Bug#258281: dh_gconf: postinst fragment crashes if gconfd-2 is not running

--C1iGAkRnbeBonpVg
Content-Type: multipart/mixed; boundary="DSayHWYpDlRfCAAQ"
Content-Disposition: inline

--DSayHWYpDlRfCAAQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Zack Weinberg wrote:
> Package: debhelper
> Version: 4.2.12
> Severity: grave
> File: /usr/bin/dh_gconf
> Justification: renders packages uninstallable
>=20
> dh_gconf generates postinst fragments that contain the line
>=20
> kill -HUP `pidof gconfd-2`

No it doesn't.=20

joey@dragon:/usr/share/debhelper/autoscripts>grep gconfd-2 * /usr/bin/dh_gc=
onf
zsh: exit 1 grep gconfd-2 * /usr/bin/dh_gconf

Two days ago, Josselin Mouette mailed me a new version of dh_gconf that
behaves as you describe, but I never uploaded a version of debhelper with
it (because Josselin did not send it as a patch or describe the changes,
and I did not yet have enough time to look over it and figure out what
he changed). Today he sent me a new version which seems to avoid that
problem. It had a few problems which I've fixed (a bashism) and I'm planning
to release debhelper with the attached patch tomorrow if Josselin confirms
it works.

Anyway, I don't know what version of debhelper or dh_gconf you're using, but
it's not one in the archive, and so I close this bug.

--=20
see shy jo

--DSayHWYpDlRfCAAQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff
Content-Transfer-Encoding: quoted-printable

Index: autoscripts/postinst-gconf
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- autoscripts/postinst-gconf (revision 1694)
+++ autoscripts/postinst-gconf (working copy)
@@ -1,5 +1,5 @@
if [ "$1" =3D "configure" ]; then
- SCHEMA_LOCATION=3D/etc/gconf/schemas
+ SCHEMA_LOCATION=3D/usr/share/gconf/schemas
  SCHEMA_FILES=3D"#SCHEMAS#"
  for SCHEMA in $SCHEMA_FILES; do
   if [ -e $SCHEMA_LOCATION/$SCHEMA ]; then
@@ -8,4 +8,6 @@
     --makefile-install-rule $SCHEMA_LOCATION/$SCHEMA > /dev/null
   fi
  done
+
+ kill -HUP `pidof gconfd-2` >/dev/null 2>&1 || true
fi
Index: autoscripts/prerm-gconf
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- autoscripts/prerm-gconf (revision 1694)
+++ autoscripts/prerm-gconf (working copy)
@@ -1,5 +1,5 @@
if [ "$1" =3D remove ] || [ "$1" =3D upgrade ]; then
- SCHEMA_LOCATION=3D/etc/gconf/schemas
+ SCHEMA_LOCATION=3D/usr/share/gconf/schemas
  SCHEMA_FILES=3D"#SCHEMAS#"
  for SCHEMA in $SCHEMA_FILES; do
   if [ -e $SCHEMA_LOCATION/$SCHEMA ]; then
Index: debian/changelog
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3...

Message-ID: <20040708201532.GC28435@kitenet.net>
Date: Thu, 8 Jul 2004 16:15:32 -0400
From: Joey Hess <joeyh@debian.org>
To: Zack Weinberg <zack@codesourcery.com>,
	258281-done@bugs.debian.org
Cc: Josselin Mouette <joss@debian.org>
Subject: Re: Bug#258281: dh_gconf: postinst fragment crashes if gconfd-2 is not running

--C1iGAkRnbeBonpVg
Content-Type: multipart/mixed; boundary="DSayHWYpDlRfCAAQ"
Content-Disposition: inline

--DSayHWYpDlRfCAAQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Zack Weinberg wrote:
> Package: debhelper
> Version: 4.2.12
> Severity: grave
> File: /usr/bin/dh_gconf
> Justification: renders packages uninstallable
>=20
> dh_gconf generates postinst fragments that contain the line
>=20
> 	kill -HUP `pidof gconfd-2`

No it doesn't.=20

joey@dragon:/usr/share/debhelper/autoscripts>grep gconfd-2 * /usr/bin/dh_gc=
onf
zsh: exit 1     grep gconfd-2 * /usr/bin/dh_gconf

Two days ago, Josselin Mouette mailed me a new version of dh_gconf that
behaves as you describe, but I never uploaded a version of debhelper with
it (because Josselin did not send it as a patch or describe the changes,
and I did not yet have enough time to look over it and figure out what
he changed). Today he sent me a new version which seems to avoid that
problem. It had a few problems which I've fixed (a bashism) and I'm planning
to release debhelper with the attached patch tomorrow if Josselin confirms
it works.

Anyway, I don't know what version of debhelper or dh_gconf you're using, but
it's not one in the archive, and so I close this bug.

--=20
see shy jo

--DSayHWYpDlRfCAAQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff
Content-Transfer-Encoding: quoted-printable

Index: autoscripts/postinst-gconf
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- autoscripts/postinst-gconf	(revision 1694)
+++ autoscripts/postinst-gconf	(working copy)
@@ -1,5 +1,5 @@
 if [ "$1" =3D "configure" ]; then
-	SCHEMA_LOCATION=3D/etc/gconf/schemas
+	SCHEMA_LOCATION=3D/usr/share/gconf/schemas
 	SCHEMA_FILES=3D"#SCHEMAS#"
 	for SCHEMA in $SCHEMA_FILES; do
 		if [ -e $SCHEMA_LOCATION/$SCHEMA ]; then
@@ -8,4 +8,6 @@
 				--makefile-install-rule $SCHEMA_LOCATION/$SCHEMA > /dev/null
 		fi
 	done
+
+	kill -HUP `pidof gconfd-2` >/dev/null 2>&1 || true
 fi
Index: autoscripts/prerm-gconf
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- autoscripts/prerm-gconf	(revision 1694)
+++ autoscripts/prerm-gconf	(working copy)
@@ -1,5 +1,5 @@
 if [ "$1" =3D remove ] || [ "$1" =3D upgrade ]; then
-	SCHEMA_LOCATION=3D/etc/gconf/schemas
+	SCHEMA_LOCATION=3D/usr/share/gconf/schemas
 	SCHEMA_FILES=3D"#SCHEMAS#"
 	for SCHEMA in $SCHEMA_FILES; do
 		if [ -e $SCHEMA_LOCATION/$SCHEMA ]; then
Index: debian/changelog
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- debian/changelog	(revision 1694)
+++ debian/changelog	(working copy)
@@ -1,6 +1,13 @@
 debhelper (4.2.13) UNRELEASED; urgency=3Dlow
=20
   * Spanish man page updates from Ruben Porras. Closes: #247382
+  * dh_gconf: gconf schemas moved to /usr/share/gconf/schemas. Relocate
+    schemas from /etc/gconf/schemas. (Josselin Mouette)
+  * dh_gconf: kill gconfd-2 so that the newly installed schemas
+    are available straight away. (Josselin Mouette)
+  * dh_gconf: fix bashism in restart of gconfd-2
+  * dh_gconf: fix innaccuracy in man page; gconfd-2 is HUPPed, not
+    killed.
=20
  -- Joey Hess <joeyh@debian.org>  Tue,  6 Jul 2004 12:52:30 -0400
=20
Index: dh_gconf
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- dh_gconf	(revision 1694)
+++ dh_gconf	(working copy)
@@ -21,22 +21,36 @@
 It automatically generates the postinst and prerm fragments needed
 to register and unregister the schemas in etc/gconf/schemas.
 These fragements will use gconftool-2, so the package should depend on
-gconf2. This rogram will add an apprioriate dependency to ${misc:Depends}.
+gconf2. This program will add an appropriate dependency to ${misc:Depends}.
=20
+The postinst script will also signal gconfd-2 so that the newly installed
+schemas are available straight away.
+
 =3Dcut
=20
 init();
=20
+
 foreach my $package (@{$dh{DOPACKAGES}}) {
 	my $tmp=3Dtmpdir($package);
+	my $old_schemas_dir =3D "$tmp/etc/gconf/schemas";
+	my $new_schemas_dir =3D "$tmp/usr/share/gconf/schemas";
=20
-	if (-d "$tmp/etc/gconf/schemas") {
+	# Migrate schemas from /etc/gconf/schemas to /usr/share/gconf/schemas
+	if (-d $old_schemas_dir) {
+		doit("mkdir -p $new_schemas_dir") unless -d $new_schemas_dir;
+		doit("mv $old_schemas_dir/*.schemas $new_schemas_dir/");
+		doit("rmdir --ignore-fail-on-non-empty $old_schemas_dir");
+	}
+
+	if (-d "$new_schemas_dir") {
 		# Get a list of the schemas
-		my $schemas =3D `find debian/$package/etc/gconf/schemas -type f -name \*=
=2Eschemas -printf '%P '`;
+		my $schemas =3D `find $new_schemas_dir -type f -name \*.schemas -printf =
'%P '`;
 		if ($schemas ne '') {
 			autoscript($package,"postinst","postinst-gconf","s%#SCHEMAS#%$schemas%"=
);
 			autoscript($package,"prerm","prerm-gconf","s%#SCHEMAS#%$schemas%");
-			addsubstvar($package, "misc:Depends", "gconf2 (>=3D 2.4.0)");
+			autoscript($package,"postrm","postrm-gconf","s%#SCHEMAS#%$schemas%");
+			addsubstvar($package, "misc:Depends", "gconf2 (>=3D 2.6.2-1)");
 		}
 	}
 }

--DSayHWYpDlRfCAAQ--

--C1iGAkRnbeBonpVg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA7atjd8HHehbQuO8RAsf4AKDKCB6tcA/rDK+JgqkN49UXeETkKQCgkES/
le/W1oUKk0AjOQpjy767SKM=
=Yteb
-----END PGP SIGNATURE-----

--C1iGAkRnbeBonpVg--

Revision history for this message

Matt Zimmerman (mdz) wrote on 2004-07-08:

#6

joeyh says this bug report doesn't apply to any released version of debhelper

Revision history for this message

In Debian Bug tracker #258281, Joey Hess (joeyh) wrote on 2004-07-08: reopening 258281, reassign 258281 to gnome-session

#7

# Automatically generated email from bts, devscripts version 2.7.95.1
reopen 258281
reassign 258281 gnome-session

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2004-07-08:

#8

Message-ID: <email address hidden>
Date: Thu, 08 Jul 2004 13:32:06 -0700
From: Zack Weinberg <email address hidden>
To: Joey Hess <email address hidden>
Cc: <email address hidden>, Josselin Mouette <email address hidden>
Subject: Re: Bug#258281: dh_gconf: postinst fragment crashes if gconfd-2 is
not running

Joey Hess <email address hidden> writes:

>> dh_gconf generates postinst fragments that contain the line
>>
>> kill -HUP `pidof gconfd-2`
>
> No it doesn't.
>
> joey@dragon:/usr/share/debhelper/autoscripts>grep gconfd-2 * /usr/bin/dh_gconf
> zsh: exit 1 grep gconfd-2 * /usr/bin/dh_gconf

Sorry. I should have checked a little more carefully. I took the
contents of /var/lib/dpkg/info/gnome-session.postinst at face value.
It seems that the buggy version of dh_gconf was used to generate that
file; can I suggest you reassign the bug to gnome-session instead of
closing it?

zw

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2004-07-08:

#9

Message-Id: <email address hidden>
Date: Thu, 8 Jul 2004 17:49:17 -0400
From: Joey Hess <email address hidden>
To: <email address hidden>
Subject: reopening 258281, reassign 258281 to gnome-session

# Automatically generated email from bts, devscripts version 2.7.95.1
reopen 258281
reassign 258281 gnome-session

Revision history for this message

Matt Zimmerman (mdz) wrote on 2004-07-08:

#10

Real bug, but not in warty's gnome-session

Revision history for this message

In Debian Bug tracker #258281, Josselin Mouette (joss) wrote on 2004-07-09: Re: Bug#258281: dh_gconf: postinst fragment crashes if gconfd-2 is not running

#11

Le jeu, 08/07/2004 à 16:15 -0400, Joey Hess a écrit :
> Two days ago, Josselin Mouette mailed me a new version of dh_gconf that
> behaves as you describe, but I never uploaded a version of debhelper with
> it (because Josselin did not send it as a patch or describe the changes,
> and I did not yet have enough time to look over it and figure out what
> he changed). Today he sent me a new version which seems to avoid that
> problem. It had a few problems which I've fixed (a bashism) and I'm planning
> to release debhelper with the attached patch tomorrow if Josselin confirms
> it works.

Yes, I'm sorry, I've uploaded a gnome-session package built with my
local version of dh_gconf, which had this buggy line.

I've uploaded a fixed gnome-session, and I can confirm that the version
I sent you is working properly.

Regards,
--
.''`. Josselin Mouette /\./\
: :' : <email address hidden>
`. `' <email address hidden>
`- Debian GNU/Linux -- The power of freedom

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2004-07-09:

#12

Message-Id: <email address hidden>
Date: Fri, 09 Jul 2004 18:08:22 +0200
From: Josselin Mouette <email address hidden>
To: Joey Hess <email address hidden>
Cc: Zack Weinberg <email address hidden>, <email address hidden>
Subject: Re: Bug#258281: dh_gconf: postinst fragment crashes if gconfd-2 is
not running

--=-W+AASLcgS0lSjd/5zswK
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Le jeu, 08/07/2004 =E0 16:15 -0400, Joey Hess a =E9crit :
> Two days ago, Josselin Mouette mailed me a new version of dh_gconf that
> behaves as you describe, but I never uploaded a version of debhelper with
> it (because Josselin did not send it as a patch or describe the changes,
> and I did not yet have enough time to look over it and figure out what
> he changed). Today he sent me a new version which seems to avoid that
> problem. It had a few problems which I've fixed (a bashism) and I'm plann=
ing
> to release debhelper with the attached patch tomorrow if Josselin confirm=
s
> it works.

Yes, I'm sorry, I've uploaded a gnome-session package built with my
local version of dh_gconf, which had this buggy line.

I've uploaded a fixed gnome-session, and I can confirm that the version
I sent you is working properly.

Regards,
--=20
.''`. Josselin Mouette /\./\
: :' : <email address hidden>
`. `' <email address hidden>
`- Debian GNU/Linux -- The power of freedom

--=-W+AASLcgS0lSjd/5zswK
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Ceci est une partie de message
=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBA7sL2rSla4ddfhTMRAgA4AJ9Q9um8DUMobTylESMkrZSK10NE6wCgxbU5
81H3HI3lfjTQd3NO/EZQUyg=
=zVL1
-----END PGP SIGNATURE-----

--=-W+AASLcgS0lSjd/5zswK--

Bug Watch Updater (bug-watch-updater) on 2006-09-27

Changed in debhelper:
status:	Unknown → Fix Released

Affects		Status	Importance	Assigned to	Milestone
	debhelper (Debian)	Fix Released	Unknown	debbugs #258281
	debhelper (Ubuntu)	Invalid	Medium	Unassigned

Ubuntu
debhelper package

dh_gconf: postinst fragment crashes if gconfd-2 is not running

Bug Description

Other bug subscribers

Remote bug watches

Ubuntudebhelper package

dh_gconf: postinst fragment crashes if gconfd-2 is not running

Bug Description

Other bug subscribers

Remote bug watches

Ubuntu
debhelper package