Missing dependency on patch

Bug #69689 reported by Adam Collard
2
Affects Status Importance Assigned to Milestone
meld (Ubuntu)
Fix Released
Wishlist
Lionel Porcheron

Bug Description

Binary package hint: meld

Meld should depend on patch. If patch is not installed then the following traceback is seen when attempting to view a diff of a file.

Traceback (most recent call last):
  File "/usr/lib/meld/task.py", line 131, in iteration
    ret = task()
  File "/usr/lib/meld/vcview.py", line 302, in run_diff_iter
    self.show_patch(prefix, patch)
  File "/usr/lib/meld/vcview.py", line 441, in show_patch
    misc.write_pipe(patchcmd, patch)
  File "/usr/lib/meld/misc.py", line 189, in write_pipe
    pipe.tochild.close()
IOError: [Errno 32] Broken pipe

Changed in meld:
status: Unconfirmed → Confirmed
Changed in meld:
assignee: nobody → adam-collard
status: Confirmed → In Progress
Revision history for this message
Adam Collard (adam-collard) wrote :

Added patch as an additional dependancy.

Changed in meld:
assignee: adam-collard → nobody
status: In Progress → Confirmed
Revision history for this message
Adam Collard (adam-collard) wrote :

MOTU: this is my first bug fix so please review and give me feedback if it's not up to scratch. Thanks

Revision history for this message
Lionel Porcheron (lionel.porcheron) wrote :

Format: 1.7
Date: Thu, 14 Jun 2007 15:36:03 +0200
Source: meld
Binary: meld
Architecture: source
Version: 1.1.5-1ubuntu1
Distribution: gutsy
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Lionel Porcheron <email address hidden>
Description:
 meld - graphical tool to diff and merge files
Changes:
 meld (1.1.5-1ubuntu1) gutsy; urgency=low
 .
   * debian/{control,control.in}: add patch as a Dependency. Thanks Adam
     Collard (Closes: LP #69689)
   * Modify Maintainer value to match Debian-Maintainer-Field Spec
Files:
 825bad898b3c1f9558ac0bb2a0e66f37 904 gnome optional meld_1.1.5-1ubuntu1.dsc
 3d7815207cc8199380bd6e9bf25c7f09 4525 gnome optional meld_1.1.5-1ubuntu1.diff.gz
Original-Maintainer: Ross Burton <email address hidden>

Changed in meld:
importance: Undecided → Wishlist
status: Confirmed → Fix Committed
assignee: nobody → lionel.porcheron
Revision history for this message
Lionel Porcheron (lionel.porcheron) wrote :

Thanks Adam for you patch. To go ahead, next time, you can generate a full debdiff. Check https://wiki.ubuntu.com/MOTU/Recipes/Debdiff for more informations on how to do that. That way, a sponsor (like me), will only have to apply your patch and get it uploaded.

Thanks for contributing!

Revision history for this message
Andy Price (andy-price) wrote :

Builds of meld - 1.1.5-1ubuntu1

    * gutsy i386 Successfully built

-> Fix released

Changed in meld:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.