raises exception on refs/stash

[Jelmer Vernooij]

_check_refname() raises an exception when it encounters a ref with the name refs/stash, which should be considered valid.

[Jelmer Vernooij (jelmer)]

Should we call check_ref_name() simply on name rather than on name[5:]

[Dave Borowitz (dborowitz)]

check_ref_format() is defined to be the same as git check-ref-format. The specifications in git-check-ref-format(1) apply to the part after "refs/".

Problem is, stash is an invalid ref name. From git-check-ref-format(1):
git imposes the following rules on how references are named:
...
2. They must contain at least one /. This enforces the presence of a category like heads/, tags/ etc. but the actual names are not restricted.

I think this is the cause of some issues in C git, like the stash not being able to be pushed/pulled.

IMO this means we should hard-code support for stash in RefsContainer._check_refname; we already do that for HEAD, so there's some precedent. If we want stash to be handled more consistently, we should probably take that up with the C git folks.

[Jelmer Vernooij (jelmer)]

works for me