unused helper ZeitgeistRemoteDataSourceRegistryTest._register_data_source_python_api() is broken

Bug #695297 reported by Markus Korn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Low
Siegfried Gevatter

Bug Description

I'm talking about

 def _register_data_source_python_api(self, *args):
  mainloop = gobject.MainLoop()
  self.client.register_data_source(*args,
   reply_handler=lambda: mainloop.quit(),
   error_handler=lambda: fail("Error registering data-source"))
  mainloop.run()

* In error_handler it should be self.fail(...)
* register_data_source() has no reply_handler/error_handler arguments

On the other hand, this method isn't used anywhere

@Siegfried, I think you added this code recently, can you please fix it. Thanks so much ;)

Related branches

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Yeah, removed that. Thanks for spotting.

Changed in zeitgeist:
assignee: nobody → Siegfried Gevatter (rainct)
importance: Undecided → Low
milestone: none → 0.7.0
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.