autocommit=1 not resetting session->server_status properly when committing ongoing txn
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Drizzle |
Fix Released
|
Low
|
Stewart Smith | ||
7.0 |
Fix Released
|
Low
|
Stewart Smith |
Bug Description
from delete.test:
SET AUTOCOMMIT=0;
DELETE from t1;
SET AUTOCOMMIT=1;
drop table t1;
#
# Test of delete when the delete will cause a node to disappear and reappear
# (This assumes a block size of 1024)
#
create table t1 (
a bigint not null,
b bigint not null default 0,
c bigint not null default 0,
d bigint not null default 0,
e bigint not null default 0,
f bigint not null default 0,
g bigint not null default 0,
h bigint not null default 0,
i bigint not null default 0,
j bigint not null default 0,
primary key (a,b,c,
with this in the create table path:
if (session-
{
my_
return true;
}
throws an error when it shouldn't. (only create table has been modifide)
Related branches
- Lee Bieber: Pending requested
- Brian Aker: Pending requested
-
Diff: 1279 lines (+275/-69)79 files modifieddocs/transactional.rst (+8/-2)
drizzled/error.cc (+2/-0)
drizzled/error_t.h (+2/-2)
drizzled/statement/alter_schema.cc (+1/-3)
drizzled/statement/alter_table.cc (+4/-2)
drizzled/statement/create_index.cc (+2/-1)
drizzled/statement/create_schema.cc (+2/-1)
drizzled/statement/create_table.cc (+2/-3)
drizzled/statement/drop_index.cc (+2/-1)
drizzled/statement/drop_schema.cc (+5/-9)
drizzled/statement/drop_table.cc (+2/-1)
drizzled/statement/rename_table.cc (+8/-1)
drizzled/statement/truncate.cc (+3/-11)
drizzled/sys_var.cc (+15/-6)
plugin/haildb/tests/r/trx_isolation_read_uncommitted.result (+1/-0)
plugin/haildb/tests/r/trx_isolation_repeatable_read.result (+1/-0)
plugin/haildb/tests/r/trx_isolation_serializable.result (+1/-0)
plugin/haildb/tests/t/trx_isolation_read_uncommitted.test (+1/-0)
plugin/haildb/tests/t/trx_isolation_repeatable_read.test (+1/-0)
plugin/haildb/tests/t/trx_isolation_serializable.test (+1/-0)
plugin/innobase/tests/r/innodb-semi-consistent.result (+1/-0)
plugin/innobase/tests/r/innodb.result (+6/-1)
plugin/innobase/tests/r/innodb_bug51920.result (+1/-0)
plugin/innobase/tests/r/innodb_bug53674.result (+1/-0)
plugin/innobase/tests/r/innodb_mysql.result (+1/-0)
plugin/innobase/tests/r/unsafe_binlog_innodb.result (+1/-0)
plugin/innobase/tests/t/innodb-semi-consistent.test (+1/-0)
plugin/innobase/tests/t/innodb.test (+6/-1)
plugin/innobase/tests/t/innodb_bug51920.test (+1/-0)
plugin/innobase/tests/t/innodb_bug53674.test (+1/-0)
plugin/myisam/tests/r/mix2_myisam.result (+1/-0)
plugin/storage_engine_api_tester/tests/r/transaction.result (+1/-0)
plugin/storage_engine_api_tester/tests/t/transaction.test (+1/-0)
plugin/transaction_log/tests/r/auto_commit.result (+1/-0)
plugin/transaction_log/tests/r/transaction_log_transaction.result (+1/-0)
plugin/transaction_log/tests/t/auto_commit.inc (+1/-0)
plugin/transaction_log/tests/t/transaction_log_transaction.test (+1/-1)
plugin/utility_functions/tests/r/execute_wait.result (+23/-7)
plugin/utility_functions/tests/t/execute_wait.test (+10/-3)
tests/include.am (+1/-1)
tests/include/mix1.inc (+1/-0)
tests/include/mix2.inc (+1/-0)
tests/include/unsafe_binlog.inc (+1/-0)
tests/r/flush_block_commit.result (+1/-0)
tests/r/insert.result (+1/-0)
tests/r/randgen_queries.result (+1/-0)
tests/r/savepoints.result (+3/-0)
tests/r/select_in_null.result (+0/-2)
tests/r/statement_boundaries.result (+3/-1)
tests/r/transaction.result (+1/-0)
tests/r/trx_isolation_read_committed.result (+1/-0)
tests/suite/ddl_transactions/r/alter_schema.result (+6/-0)
tests/suite/ddl_transactions/r/alter_table.result (+8/-0)
tests/suite/ddl_transactions/r/create_index.result (+6/-0)
tests/suite/ddl_transactions/r/create_schema.result (+6/-0)
tests/suite/ddl_transactions/r/create_table.result (+4/-0)
tests/suite/ddl_transactions/r/drop_index.result (+6/-0)
tests/suite/ddl_transactions/r/drop_schema.result (+6/-0)
tests/suite/ddl_transactions/r/drop_table.result (+6/-0)
tests/suite/ddl_transactions/r/rename_table.result (+8/-0)
tests/suite/ddl_transactions/r/truncate_table.result (+7/-0)
tests/suite/ddl_transactions/t/alter_schema.test (+6/-0)
tests/suite/ddl_transactions/t/alter_table.test (+8/-0)
tests/suite/ddl_transactions/t/create_index.test (+6/-0)
tests/suite/ddl_transactions/t/create_schema.test (+6/-0)
tests/suite/ddl_transactions/t/create_table.test (+4/-0)
tests/suite/ddl_transactions/t/drop_index.test (+6/-0)
tests/suite/ddl_transactions/t/drop_schema.test (+6/-0)
tests/suite/ddl_transactions/t/drop_table.test (+6/-0)
tests/suite/ddl_transactions/t/rename_table.test (+6/-0)
tests/suite/ddl_transactions/t/truncate_table.test (+7/-0)
tests/t/flush_block_commit.test (+1/-1)
tests/t/insert.test (+1/-1)
tests/t/randgen_queries.test (+1/-1)
tests/t/savepoints.test (+3/-1)
tests/t/select_in_null.test (+0/-2)
tests/t/statement_boundaries.test (+4/-3)
tests/t/transaction.test (+1/-0)
tests/t/trx_isolation_read_committed.test (+1/-0)
Changed in drizzle: | |
assignee: | nobody → Stewart Smith (stewart) |
Changed in drizzle: | |
status: | New → In Progress |
summary: |
- drop table implicit commit leaves inTransaction as true + autocommit=1 not resetting session->server_status properly when + committing ongoing txn |
Changed in drizzle: | |
importance: | Undecided → Low |
milestone: | none → 2011-01-03 |
Changed in drizzle: | |
milestone: | 2011-01-03 → 2011-01-17 |
Changed in drizzle: | |
status: | In Progress → Fix Committed |