commit --exclude misses deleted files
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
When committing with --exclude'd files, commit takes no notice of removed files. Note that using `bzr rm` rather than `rm` appears to make no difference. Additional variant of exclude'ing a file that doesn't exist at all (e.g., 'c' in example below) also changes nothing.
Output ends:
+ /usr/local/bin/bzr --no-plugins --no-aliases stat
removed:
b
+ /usr/local/bin/bzr --no-plugins --no-aliases ci -x a -m remove
Committing to: /tmp/bzr/t/A/
missing b
aborting commit write group: PointlessCommit(No changes to commit)
bzr: ERROR: No changes to commit. Use --unchanged to commit anyhow.
Repro script:
#!/bin/sh -x
bzr="/usr/
${bzr} init A
(
# Setup
cd A ; \
touch a b ; \
${bzr} add ; \
${bzr} ci -m add ; \
# Remove b
rm b ; \
#${bzr} rm --force b ; \
${bzr} stat ; \
# Commit everything but a (which has no changes anyway)
${bzr} ci -x a -m remove
# Fails
)
Related branches
- Martin Packman: Approve
-
Diff: 138 lines (+70/-5)3 files modifiedbreezy/commit.py (+29/-4)
breezy/tests/test_commit.py (+38/-1)
doc/en/release-notes/brz-3.0.txt (+3/-0)
Changed in bzr: | |
importance: | Undecided → Medium |
tags: | added: commit exclude |
Changed in brz: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in brz: | |
status: | Triaged → Fix Released |
assignee: | nobody → Jelmer Vernooij (jelmer) |
milestone: | none → 3.0.0 |