reftracker and idmapfile are highly specific to bzr-fastimport, and probably shouldn't be in this library

Bug #693507 reported by Max Bowsher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Fast Import
Fix Released
Low
Jelmer Vernooij
python-fastimport
Fix Released
Low
Jelmer Vernooij

Bug Description

reftracker is some very specific code that implements a particular kind of ref-tracking in exactly the way bzr-fastimport wants it. I think it deserves reconsideration whether it should actually be factored out to a library, with the implicit commitment of maintaining a (relatively) stable API.

idmapfile is also code crafted for bzr-fastimport primarily, and is fairly confusing/meaningless outside that context - exactly what an "id map file" and why you would want one is only determined at the bzr-fastimport layer. (And for further confusion, the "id map file" has coincidentally the exact same formatting as a marks file.)

I think these two files should move back into bzr-fastimport unless there's an established need for something other that bzr-fastimport to do these things, in which case, the APIs of these modules could do with an overhaul and documentation before they go into a release.

Jelmer Vernooij (jelmer)
Changed in python-fastimport:
status: New → Triaged
importance: Undecided → Low
Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
status: New → Fix Committed
importance: Undecided → Low
Changed in python-fastimport:
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in python-fastimport:
milestone: none → 0.9.2
status: Triaged → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
milestone: none → 0.13.0
status: Fix Committed → Fix Released
Jelmer Vernooij (jelmer)
Changed in python-fastimport:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.