Tests depending on archive engine should be skipped if archive isn't enabled

Bug #693130 reported by David Shrewsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
Wishlist
Patrick Crews
7.0
Fix Released
Wishlist
Patrick Crews

Bug Description

The main.drizzledump-max test fails if the server is configured with --without-archive-plugin.

We should skip the test if archive engine isn't enabled.

Related branches

Changed in drizzle:
assignee: nobody → Patrick Crews (patrick-crews)
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Patrick Crews (patrick-crews) wrote :

This is a weakness of test-run.pl

The problem is as follows:
* We need the archive plugin to run drizzledump-max
* We have to use a master-opt.file using --plugin-add=archive as the plugin is not loaded by default
* If we are configured --without-archive-plugin, this will cause the server to fail to startup:
Can't open shared library '/drizzle/plugin/.libs/libarchive_plugin.so' (errno: 2 /drizzle/plugin/.libs/libarchive_plugin.so: cannot open shared object file: No such file or d)Couldn't load plugin library named 'archive'.
* We have no smart way of describing these contingencies via test-run.pl / the test language

Will move drizzledump-max to the archive suite as it really is a largely archive-related test anyway. However, note that the archive suite will fail if we are configured --without-archive-plugin.

This will hold true for any configure '--without-<plugin>-plugin' and running said plugins suite.

Changed in drizzle:
status: Confirmed → In Progress
milestone: none → 2011-01-17
Changed in drizzle:
status: In Progress → Fix Committed
Revision history for this message
Patrick Crews (patrick-crews) wrote :

To clarify the above:
The way test-run.pl works is to try to start up the server first. There is no way to describe any checks that should be done on the server *prior* to starting it up. It will just blindly try to start the server with the master.opt options. (ie we can't check nor can we describe that we should check server configs before firing up a drizzled server)

The test-file level checks from the include files, such as have_archive.inc are run on the running server.

You can see how this would be an issue - we can't skip the test as we need the running server to see if we should run or not...we start the server blindly, but it never starts due to a bad / impossible option = test-fail

While the change in test files makes sense, I believe that we can fix this in an improved test-runner - ie we start a server initially and check out what is available - we use this as a means of allowing smarter test analysis (should we run / etc)

Moving to wishlist priority.

Changed in drizzle:
status: Fix Committed → In Progress
importance: Low → Wishlist
milestone: 2011-01-17 → future
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.