Reporting objectionable content link should ask for confirmation

[François Marier]

Apparently some people click the "report this view" link thinking they are posting view feedback.

This is a usability problem.

[Sean Brennan (the-ioniser)]

I have added a popup confirm dialogue before the submission of this. It was a small modification of the javascript used to create the form.
Should I try to avoid javascript at all costs instead and for future modifications?
for example, should I convert this "popup" into a yes no form like on other parts of mahara?

[François Marier (fmarier)]

It would be better to be consistent with other similar areas in Mahara.

Also, we're hoping that someday Mahara will gracefully degrade but still be usable when Javascript is turned off. So if you can easily do something without Javascript, that's probably a good idea.

[Richard Mansfield (richard-mansfield)]

I think a javascript confirm popup is fine for this, but some people will say it breaks consistency with some of the other confirmation pages. I doubt this is actually a widespread problem anyway, I mean the button text says 'Notify Site Administrator', it's pretty obvious!

[Sean Brennan (the-ioniser)]

we really need a message template that is used for all messages where we plug in the type and text to be shown. this would remove the need for javascript of a second pieform to display a unique template for each one. could this be added as an addition to the pieform submit?

[Sean Brennan (the-ioniser)]

the simple fix for this is here
http://www.gitorious.org/~ioniser/mahara/ionisers-mahara/commits/lp692784-objectional-content-link-should-confirm

I will also start an experimental branch to try out replacing all confirm forms with one customisable one. This will include a richer jquery confirm dialogue if javascript is turned on, and a pieform confirm/error/warning template page if off.

[Sean Brennan (the-ioniser)]

ignore the link in the previous comment. I accidentally turned on remove white space.

[Sean Brennan (the-ioniser)]

fixed and attached patch.

[François Marier (fmarier)]

Patch needs to be reviewed and tested.

[Melissa Draper (melissa)]

Patch refers to the page as "view" which is a recent change as per bug 771152 and will hence need re-rolling.