Placeholder event "boo" presented on hold note creation in staff client

[Dmagick]

This bug is found in the Evergreen rel_2_0_beta2 Staff Client.

When creating a hold note on a patron in the Detailed View, a developer placeholder window appears that simply says, "boo".

The origin of this event is found in line 31 of /build/staff_client/server/patron/hold_details.js. Below is the current relevant section of code:

        if (xulG.ahr_id) fetch_and_render_all();

    } catch(E) {
        try { g.error.standard_unexpected_error_alert('/xul/server/patron/hold_notices.xul',E); } catch(E) { alert('FIXME: ' + js2JSON(E)); }
    }
}

function fetch_and_render_all() {
    try {
        if (!xulG.ahr_id) { alert('boo'); return; }

        fetch_hold();

        if (xulG.patron_rendered_elsewhere) {
            // Hide patron line
        } else {
            render_patron();

It appears that the issue is not in function, but rather the lack of informational error messages.

[Jason Stephenson (jstephenson)]

This message only appears if you attempt to create a hold note in the Detail View when there is no hold selected. It appears after a FIXME error dialog.

I recommend removing the "boo" dialog and possibly making so the Detail View button is not active unless a hold is selected in the List View.

[Jason Stephenson (jstephenson)]

I just bumped the importance of this because I saw it happen with a hold selected in the Detail View. I'll see what additional information I can gather.

[Jason Stephenson (jstephenson)]

When the above occurs with a note selected, the notes don't appear in the Detail View until you refresh the whole view, or go back to List View and then return to Detail View.

Whatever is causing this, also seems to be related to bug #691596. That is, I didn't see the first par of that bug occur until "boo" started showing up when a hold note was being created on an actual hold note. From looking at the code, though, it should not be happening. :(

[Jason Stephenson (jstephenson)]

The following appear in the JS Console when this error occurs.

[Steven Chan (schan2)]

At Sitka, we have a library staff person using client 2.0.5 reporting the alert boo error while she was trying to create a hold note.

It is likely this line of code in the function new_note() that is triggering the alert box:

setTimeout(function(){fetch_and_render_all();},0);

--
steven chan
<email address hidden>

[Jason Etheridge (phasefx)]

remove_boo_alert @ working/Evergreen.git

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/remove_boo_alert

commit 40e5b29dc714caa5671fb269a8cc45e7c0f0ca36
Author: Jason Etheridge <email address hidden>
Date: Tue Jan 10 11:55:20 2012 -0500

    Remove 'boo' alert in hold details interface

    Willing to let any surprises here be natural. :-) We can re-bug if there are
    issues.

    Signed-off-by: Jason Etheridge <email address hidden>

diff --git a/Open-ILS/xul/staff_client/server/patron/hold_details.js b/Open-ILS/xul/staff_client/server/patron/hold_details.js
index aa28075..aaace8b 100644
--- a/Open-ILS/xul/staff_client/server/patron/hold_details.js
+++ b/Open-ILS/xul/staff_client/server/patron/hold_details.js
@@ -32,7 +32,7 @@ function my_init() {

 function fetch_and_render_all(do_not_refresh_parent_interface) {
     try {
- if (!xulG.ahr_id) { alert('boo'); return; }
+ if (!xulG.ahr_id) { return; }

         fetch_hold();

[Bill Erickson (berick)]

Merged to master, rel_2_1, and rel_2_0. Thanks.