Auditors Duplicate Tests and Miss Entire Devices
Bug #691254 reported by
Travis W Kiel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Object Storage (swift) |
Fix Released
|
Undecided
|
David Goetz | ||
Bug Description
Version: trunk rev 145
When a node has more than one device/disk, the account, container, obj auditors are duplicating tests against the first device found, and are not actually testing the other devices. This of course means that many objects go unaudited.
The auditors call on swift.common.
The problem is that the 'objects' directory is supplied in arguments to audit_location_
Attached is a fixed swift.common.
Related branches
lp:~david-goetz/swift/slow_audit
- gholt (community): Approve
-
Diff: 635 lines (+380/-60)7 files modifieddoc/source/deployment_guide.rst (+6/-1)
etc/object-server.conf-sample (+2/-2)
swift/common/utils.py (+36/-6)
swift/obj/auditor.py (+50/-36)
swift/obj/server.py (+18/-7)
test/unit/common/test_utils.py (+45/-5)
test/unit/obj/test_auditor.py (+223/-3)
Revision history for this message
| Travis W Kiel (twkiel) wrote | #1 |
Revision history for this message
| David Goetz (david-goetz) wrote | #2 |
| Changed in swift: | |
| assignee: | nobody → David Goetz (david-goetz) |
| Changed in swift: | |
| status: | New → Fix Committed |
| Changed in swift: | |
| milestone: | none → 1.2.0 |
| Changed in swift: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm working with the obj auditor right now- I'll add this in. Thanks,
David