[spread] images from pixmaps are blueish on Efika

[Ricardo Salveti]

Images from pixmaps, while running unity-qt-spread, are blueish on Efika.

The attached screenshot shows the issue.

Also tested on my Pandaboard, but could not reproduce this issue there.

The problem is happening while setting the application color spec:
QApplication::setColorSpec(QApplication::ManyColor);

After removing it, or changing ManyColor for NormalColor or CustomColor this issue doesn't happen anymore.

[Ricardo Salveti (rsalveti)]

Here are the color differences from the platforms:
Efika: fbset -i

mode "1024x600-59"
    # D: 43.860 MHz, H: 38.205 kHz, V: 59.233 Hz
    geometry 1024 600 1024 600 16
    timings 22800 80 40 20 21 4 4
    rgba 5/11,6/5,5/0,0/0
endmode

Frame buffer device information:
    Name : DISP3 BG - DI1
    Address : 0xae000000
    Size : 33554432
    Type : PACKED PIXELS
    Visual : TRUECOLOR
    XPanStep : 1
    YPanStep : 1
    YWrapStep : 0
    LineLength : 2048
    Accelerator : No

Panda:fbset -i

mode "1920x1080-60"
    # D: 148.500 MHz, H: 67.500 kHz, V: 60.000 Hz
    geometry 1920 1080 1920 1080 32
    timings 6734 88 148 4 36 44 5
    rgba 8/16,8/8,8/0,0/0
endmode

Frame buffer device information:
    Name : omapfb
    Address : 0x81ddb000
    Size : 8294400
    Type : PACKED PIXELS
    Visual : TRUECOLOR
    XPanStep : 1
    YPanStep : 1
    YWrapStep : 0
    LineLength : 7680
    Accelerator : No

On Efika we're using RGB weight 565 and on Panda RGB weight 888, probably it the setColorSpace doesn't work well on 16bpp, for some other reason I don't know.

[Florian Boucault (fboucault)]

@Ugo: let's remove QApplication::setColorSpec(QApplication::ManyColor) from the spread *and* the dash so that when we merge them it won't raise the question.

[Ricardo Salveti (rsalveti)]

After checking at Dallas, the call to setColorSpec should still be required at least for launcher and panel, as it actually removes the ugly color from it.

So at least with the current code base, we can safely remove the call to setColorSpec from the spread, like the following patch:
diff -Naur unity-2d-0.1/spread/app/spread.cpp unity-2d-0.1-new//spread/app/spread.cpp
--- unity-2d-0.1/spread/app/spread.cpp 2011-01-14 18:59:50.000000000 -0200
+++ unity-2d-0.1-new//spread/app/spread.cpp 2011-01-18 01:13:00.839812224 -0200
@@ -43,7 +43,6 @@
        Reference: https://bugs.launchpad.net/upicek/+bug/674484
     */
     QApplication::setGraphicsSystem("raster");
- QApplication::setColorSpec(QApplication::ManyColor);
     QApplication application(argc, argv);

     SpreadView view;

[Florian Boucault (fboucault)]

Awesome Ricardo, I'll send a MR removing it from the spread and the dash. Please review and approve.

[Oliver Grawert (ogra)]

i can confirm that this fix works on the toshiba ac100 as well.