libsupport.get_launchpad doesn't automatically create LP credentials on first use

[Stefano Rivera]

Do we really need manage-credentials?

In fact, can the lp api mode of requestsync become the default (once it automatically handles application authorization)?

First issue get_launchpad.

Also, launchpadlib credentials management is changing. LP: #686690

[Michael Bienia (geser)]

I agree that we should get rid of manage-credentials (see also bug 387297) and that we could make the LP API default if there is a consensus for it.

But what you mean with "homegrown launchpad api wrapper"? ubuntutools/lp/lpapicache.py? That's relatively new to speed up requestsync. It caches objects fetched through the LP API to not refetch them (which is slow) on every use throughout the script.
Other scripts can use it too but as most are less complex there is no strong benefit from it.

[Stefano Rivera (stefanor)]

> But what you mean with "homegrown launchpad api wrapper"?

I say that because its api is rather different to launchpadlib. I wanted to use some of its convenience functions in other u-d-t tools, but there was no trivial way to do that without fully switching to lpapicache.

BTW the code also gives off some sour fumes: mixed tabs and spaces for indentation (a recipe for surprises), and CamelCase which is unusual in Python (see pep-8).

[Michael Bienia (geser)]

Any ideas how to improve it to make it easier for use?

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-dev-tools - 0.119

---------------
ubuntu-dev-tools (0.119) unstable; urgency=low

  * Support Launchpadlib 1.9. (LP: #725231, #725092)
    - Document Launchpadlib 1.9 issues in NEWS.
  * Remove manage-credentials, and credential handling code from
    ubuntutools.lp.libsupport. Launchpadlib 1.9 handles this via
    python-keyring. (LP: #387297, #645629, #689100)
  * Use Launchpadlib.login_with() directly in scripts.
  * Remove ubuntutools.lp.libsupport.approve_application, no longer used.
  * Remove ubuntutools.lp.libsupport.get_launchpad, no longer used.
  * Remove ubuntutools.lp.libsupport.translate_api_web, no longer used.
  * Skip pylint test if it crashes.
 -- Stefano Rivera <email address hidden> Tue, 01 Mar 2011 15:04:40 +0200