MinorPlanets and Comets don't get selection pointers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Stellarium |
Fix Released
|
Medium
|
Bogdan Marinov |
Bug Description
Affects: MinorPlanet objects & Comet objects which have been added to SolarSystem using the Solar System Edtior plugin.
When these objects are selected (e.g. search dialog used to select them), no pointer is drawn, which is done for other planetary bodies.
Problem appears to be that when StelObjectMgr:
Two possible solutions (I would like feedback on which is preferred:
1. MinorPlanet:
2. SolarSystem:
Comments?
Changed in stellarium: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
milestone: | none → 1.0.0 |
Changed in stellarium: | |
status: | Confirmed → In Progress |
Changed in stellarium: | |
milestone: | 1.0.0 → 0.11.0 |
Changed in stellarium: | |
assignee: | nobody → Bogdan Marinov (daggerstab) |
Changed in stellarium: | |
status: | In Progress → Fix Committed |
Changed in stellarium: | |
status: | Fix Committed → Fix Released |
SolarSystem: :drawPointer( ) is not the only method using the type string. The other two are SolarSystem: :setSelected( ) and SolarSystem: :selectedObject Change( ). The SolarSystem class was simply not created with multiple object types in mind.
Anyway, the simpler solution for now is to have the child classes return "Planet", as the type is used only in SolarSystem. I've committed this as trunk revision 4900: bazaar. launchpad. net/~stellarium /stellarium/ trunk/revision/ 4900
http://
Where else is the getType() function significant? Scripts?