Remove POTMsgSet._getUsedTranslationMessage
Bug #688519 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Henning Eggers | ||
Bug Description
Remove POTMsgSet.
Related branches
lp:~henninge/launchpad/db-devel-688519-getusedtranslationmessage
- Curtis Hovey (community): Approve (code)
- j.c.sackett (community): Approve (code*)
-
Diff: 842 lines (+199/-170)17 files modifiedlib/lp/testing/factory.py (+12/-11)
lib/lp/translations/doc/poimport.txt (+4/-4)
lib/lp/translations/doc/potmsgset.txt (+8/-8)
lib/lp/translations/interfaces/potmsgset.py (+14/-0)
lib/lp/translations/model/potmsgset.py (+34/-12)
lib/lp/translations/model/side.py (+3/-4)
lib/lp/translations/model/translatablemessage.py (+4/-3)
lib/lp/translations/model/translationmessage.py (+3/-0)
lib/lp/translations/scripts/message_sharing_migration.py (+6/-8)
lib/lp/translations/scripts/tests/test_message_sharing_migration.py (+3/-3)
lib/lp/translations/tests/helpers.py (+7/-19)
lib/lp/translations/tests/potmsgset-update-translation.txt (+11/-10)
lib/lp/translations/tests/test_potmsgset.py (+72/-66)
lib/lp/translations/tests/test_suggestions.py (+2/-3)
lib/lp/translations/tests/test_translatablemessage.py (+5/-8)
lib/lp/translations/utilities/tests/import-flags.txt (+2/-2)
lib/lp/translations/utilities/tests/test_xpi_import.py (+9/-9)
| Changed in rosetta: | |
| milestone: | 10.12 → none |
Revision history for this message
| Данило Шеган (danilo) wrote | #1 |
| Changed in rosetta: | |
| status: | Triaged → Invalid |
| summary: |
- POTMsgSet._getUsedTranslationMessage needs to be side-aware. + Remove POTMsgSet._getUsedTranslationMessage |
| Changed in rosetta: | |
| status: | Invalid → In Progress |
| assignee: | nobody → Henning Eggers (henninge) |
| description: | updated |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually, it doesn't. It simply needs to be killed — it's an obsolete method.