Headphone pre-listen depends on crossfader/sliders

[gianfe]

In the new 1.9 beta1 version the headphone volume of a deck is function of the volume slider of the corrisponding deck and is function of the crossfader position. This isn't a pre-fader listen (PFL).

My OS: Ubuntu 10.10 64 bit and I have compiled Mixxx with "optimize=6"

[gimmeapill (gimmeapill)]

Yes, I can confirm - if the volume of a track is set to 0, preview is muted as well

[Vittorio Colao (l0rdt)]

I agree too. Enclosed quick fix works for me. Is it suitable?

[William Good (bkgood)]

Fix committed to 1.9 at http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.9.x/revision/2627

Thanks for the patch Vittorio! I ended up with a slightly less involved solution (got to get rid of some stack usage actually) but it certainly steered me in the right direction :)

Also, this fix works as far as I know it should, hopefully I didn't miss any corner cases in functionality I'm not aware (or conscious) of. Test and let me know if it works as expected now. I wasn't able to get the xfader to affect headphone output pre-fix with the headphone output set to 100% pre on the pre/main dial (of course, the crossfader will affect headphone output as the pre/main setting is moved towards main but that's intended functionality).

[Vittorio Colao (l0rdt)]

Hi Bill!
Thanks a lot for taking care of this,

I am going to test it later today.
In my opinion, if headphone is 100% pre it should not be affected by xfader and faders.
In my experience, that is how physical mixers work.
So I think it is ok to pass buffer to headphone before all faders and xfader gain are applied.

[Vittorio Colao (l0rdt)]

Bill,
I tested your solution and it perfectly works.
A little reminder here:

PFL is pre-faders listen.
SOLO is post-faders.

Is a PFL/SOLO switch interesting for Mixxx or is it "too much"?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5708