Random failure on bt.test_http.SmartClientAgainstNotSmartServer.test_probe_smart_server

[Martin Packman]

On the babune windows buildbot test_probe_smart_server_urllib has been randomly failing:

<http://babune.ladeuil.net:24842/job/selftest-windows/258/testReport/bzrlib.tests.test_http/SmartClientAgainstNotSmartServer/test_probe_smart_server_urllib_HTTP_1_0_/history>

Interestingly this is only the (urllib,HTTP/1.0) variant, the (urllib,HTTP/1.1) one always passes. The exception is:

Traceback (most recent call last):
  ...
  File "...\bzrlib\tests\test_http.py", line 1859, in test_probe_smart_server
    'whatever')
  File "...\bzrlib\tests\__init__.py", line 1286, in assertRaises
    callableObj(*args, **kwargs)
  File "...\bzrlib\transport\http\__init__.py", line 615, in send_http_smart_request
    code, body_filelike = t._post(bytes)
  File "...\bzrlib\transport\http\_urllib.py", line 144, in _post
    accepted_errors=[200, 403]))
  File "...\bzrlib\transport\http\_urllib.py", line 79, in _perform
    response = self._opener.open(request)
  File "C:\Python25\lib\urllib2.py", line 381, in open
    response = self._open(req, data)
  File "C:\Python25\lib\urllib2.py", line 399, in _open
    '_open', req)
  File "C:\Python25\lib\urllib2.py", line 360, in _call_chain
    result = func(*args)
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 719, in http_open
    return self.do_open(HTTPConnection, request)
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 663, in do_open
    response = self.retry_or_raise(http_class, request, first_try)
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 580, in retry_or_raise
    response = self.do_open(http_class, request, False)
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 663, in do_open
    response = self.retry_or_raise(http_class, request, first_try)
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 659, in do_open
    response = connection.getresponse()
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 263, in getresponse
    self._response = httplib.HTTPConnection.getresponse(self)
  File "C:\Python25\lib\httplib.py", line 928, in getresponse
    response.begin()
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 184, in begin
    httplib.HTTPResponse.begin(self)
  File "C:\Python25\lib\httplib.py", line 385, in begin
    version, status, reason = self._read_status()
  File "C:\Python25\lib\httplib.py", line 343, in _read_status
    line = self.fp.readline()
  File "...\bzrlib\transport\http\_urllib2_wrappers.py", line 119, in readline
    s = self.filesock.readline()
  File "C:\Python25\lib\socket.py", line 381, in readline
    data = self._sock.recv(self._rbufsize)
ConnectionError: Connection error: while sending POST /.bzr/smart: (10053, 'Software caused connection abort')

This is the same underlying exception as in bug 581311 so the comments there apply as may a fix, however the traceback differs and that test always fails. The other random errors frequently seen involve sftp as noted in bug 681047 and are probably not related.