Lock Screen plugin

Bug #684960 reported by dotSimpl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Synapse
Fix Released
Low
Michal Hruby

Bug Description

I'm switched from Gnome Do to Synapse and really missing 'Lock Screen' action.

Related branches

Revision history for this message
dotSimpl (mandrigin) wrote :
Revision history for this message
Alberto Aldegheri (albyrock87) wrote :

Thank you for the patch, but there is something strange:
looking at the diff, it seems that you created a new plugin,
and also that you added an action to gnome-session-plugin.

There's a duplication of the code and matches.

I think I'm going to simply add the Lock action to the gnome session plugin,
is it ok for you?

Revision history for this message
dotSimpl (mandrigin) wrote :

First, I've just exteneded gnome-session-plugin. But 'Lock Screen' uses different underlying API, and I created different plugin for it.
Seems like I've just forgot to revert changes to gnome-session-plugin.vala...

Revision history for this message
Michal Hruby (mhr3) wrote :

@Alberto, I talked to dotSimpl on IRC and specifically asked him to move this into a new plugin, but yea the it'd be nice to revert the changes to g-s-p in the patch.

Changed in synapse-project:
assignee: nobody → Michal Hruby (mhr3)
importance: Undecided → Low
status: New → Triaged
milestone: none → 0.2.2
Revision history for this message
dotSimpl (mandrigin) wrote :

I've cleared unnecessary files and re-generated patch.

Revision history for this message
dotSimpl (mandrigin) wrote :

"unnecessary files" = "unnecessary file changes"

Michal Hruby (mhr3)
Changed in synapse-project:
status: Triaged → In Progress
Michal Hruby (mhr3)
Changed in synapse-project:
status: In Progress → Fix Committed
Michal Hruby (mhr3)
Changed in synapse-project:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.