Odoo Addons (MOVED TO GITHUB)

Please use string formatting instead of concatenation

Bug #684741 reported by Numérigraphe on 2010-12-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Wishlist	OpenERP R&D Addons Team 2

Bug Description

In the current trunk there are still a few places in the code where translatable strings are composed using concatenation ("+" operator) instead of string formatting ("%" operator).
That makes them hard to translate. Could you please refactor those portions of the code ?

Suspects can be found using this command on GNU/Linux : find . -name '*.py' -exec grep -RHn "_([^)]*) +" '{}' ';'.
Current results are in the file attached.

This is not an emergency - if you fix this before 6.0 is released, please do warn all the translators because the strings will have to be translated again.

Lionel Sausin

Tags:

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-684741-rha

Merged into lp:openobject-addons at revision 4555

OpenERP buildbot (community): Needs Fixing on 2011-03-09

qdp (OpenERP): Pending requested 2011-03-15

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2010-12-03:

Suspect code portions in the trunk Edit (8.4 KiB, text/plain)

tags:

added: long-term translation

Revision history for this message

Jamin Shah(OpenERP) (jamin-openerp) wrote on 2010-12-06:

Hello,

Once you(Addons2 team) make changes into your modules, please assign this bug to the other teams to make changes in their modules.

Thanks

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance:	Undecided → Wishlist
status:	New → Confirmed

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2011-03-02:

Addons Team 2, aren't you done yet ?
Lionel.

Revision history for this message

qdp (OpenERP) (qdp) wrote on 2011-03-17:

all the suggested files/portion of code have been improved with string formatting instead of string concatenation. We will continue improving this as soon as possible, in th e meanwhile i'm setting this wishlist as "fixed released", for the sake of clarity in LP.

Thanks for the contribution Numérigraphe,
Quentin.