[6.0 trunk] Cancel button on sale order cancel all modifications

Bug #684312 reported by Quentin THEURET @Amaris
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo GTK Client (MOVED TO GITHUB)
Opinion
Medium
OpenERP sa GTK client R&D

Bug Description

Open the SO001 sale order.

Open the first sale order line (with MB1). Change the product, choose CPU_GEN, and click on Save & Close button. Re-open this line without saving the whole sale order, and click on Cancel. The old product reappears in the line.

Changed in openobject-client:
assignee: nobody → OpenERP sa GTK client R&D (openerp-dev-gtk)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Quentin THEURET,

This is because when you click 'save&cancel' the gtk saves the data internally in the model and does not send it to the server to get it stored in the DB.So next time when you edit the same record without saving the parent record and click 'Cancel' it will reload the O2M list means make a rpc for read to server to return the old set of the records.

You should save the main record. If you want the modified values.

Thanks

Changed in openobject-client:
status: Confirmed → Invalid
milestone: none → 6.0-rc2
Revision history for this message
Quentin THEURET @Amaris (qtheuret) wrote :

Hello nch,

So you said me that the buttons 'Save & Close' doesn't save the line. It's a big ergonomic problem. The user will think that his line was saved when he clicked on the 'save & Close' button.

Why the reload of O2M list make a rpc for read to server without before read internally data ?

Changed in openobject-client:
status: Invalid → Opinion
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Quentin,

This is the case when the parent record is saved
yes, it saves the line internally that's the reason you can see it back when you edit it. but If you click cancel means you are telling the internal model to cancel all the modifications taken. and it reloads the model data back.

Thanks

Revision history for this message
Quentin THEURET @Amaris (qtheuret) wrote :

Hello nch,

I understand the current behaviour of the cancel button, but I think isn't the good behaviour (It's just my opinion).

I'm put in place of a user :
    * I want to modify a sale order line, because the unit price isn't correct. I open the line, I modify the unit price and i save the line.
    * At a moment, I want to know which taxes are applied on my modified line. I open it, see the taxes table and click on 'Cancel' button to close the line form.

At this moment, my unit price modification isn't kept !!

Is the good way to keep my modification is to close the line form with the 'cross' button at the top of the form ?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.