[launcher] activating a place entry does not show the activated arrow

Bug #684155 reported by Florian Boucault
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-2d
Fix Released
Medium
Olivier Tilloy

Bug Description

When a place is activated, its corresponding shortcut in the launcher should indicate that it is indeed activated by showing the typical arrow on its right hand side.

Related branches

Changed in upicek:
assignee: nobody → Olivier Tilloy (osomon)
Olivier Tilloy (osomon)
Changed in upicek:
status: Confirmed → In Progress
Olivier Tilloy (osomon)
summary: - [launcher] activating a place does not show the activated arrow
+ [launcher] activating a place entry does not show the activated arrow
Revision history for this message
Olivier Tilloy (osomon) wrote :

Because of bug #684152 ([dash] list of places is hardcoded), this issue is non-trivial to fix and involves hacks to synchronize the 'current_page' property of the dash to the 'active' property of place entries. The branch linked implements that, but we should probably fix bug #684152 first.

affects: upicek → unity-2d
Changed in unity-2d:
milestone: 0.4 → none
milestone: none → 3.4
visibility: private → public
Revision history for this message
Olivier Tilloy (osomon) wrote :

Unfortunately my assumption in comment #1 was over-optimistic. The list of place entries in the dash is now dynamic, but it’s not shared with the launcher, so their states are not synchronized.

The D-Bus interface of the place daemons (com.canonical.Unity.PlaceEntry) doesn’t expose an "active" property either.

So it seems that my original solution, deemed back then as a hack, is in fact the only solution we have at hand.

Revision history for this message
Florian Boucault (fboucault) wrote :

I will look into that. 3 possible solutions then:
- either your hack is sufficient and acceptable
- or we synchronise the states of the launcher and the dash over D-Bus
- or we push to have an "active" property in the backend side

Revision history for this message
Olivier Tilloy (osomon) wrote :

> - either your hack is sufficient and acceptable

I believe my "hack" is acceptable, but I probably need to re-work it a bit to fit changes in the code base.

> - or we synchronise the states of the launcher and the dash over D-Bus

This is roughly what my original implementation does already: it adds an "activePlaceEntry" property to the dash and an "activePlaceEntryChanged" signal to the dash’s D-Bus interface, which the place entries in the launcher monitor to update accordingly their "active" property.

Revision history for this message
Florian Boucault (fboucault) wrote :

Fantastic, let's go for that then.

Changed in unity-2d:
status: In Progress → Fix Committed
Changed in unity-2d:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.