Drizzledump not preserving column comments during migration from MySQL
Bug #683931 reported by
Patrick Crews
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Drizzle |
Fix Released
|
Medium
|
Andrew Hutchings | ||
| 7.0 |
Fix Released
|
Medium
|
Andrew Hutchings | ||
Bug Description
After migrating this table from MySQL:
CREATE TABLE t1 (a INT COMMENT '.') ENGINE=MyISAM;
We have this table on Drizzle:
SHOW CREATE TABLE drizzledump_
Table Create Table
t1 CREATE TABLE `t1` (
`a` INT DEFAULT NULL
) ENGINE=InnoDB COLLATE = utf8_general_ci
Table comments are preserved as expected.
To repeat, use the attached branch:
./test-run --suite=
To use the tests in this suite you need the following:
1) You need a running MySQL server
2) Set two environment vars:
DRIZZLE_
DRIZZLE_
Related branches
lp:~patrick-crews/drizzle/mysql-migrate-tests
- Drizzle Developers: Pending requested
-
Diff: 4505 lines (+4052/-0)90 files modifiedtests/std_data/mysqlmigrate_basic.dat (+3/-0)
tests/std_data/mysqlmigrate_binary_type.dat (+14/-0)
tests/std_data/mysqlmigrate_bit_type.dat (+18/-0)
tests/std_data/mysqlmigrate_blob_type.dat (+41/-0)
tests/std_data/mysqlmigrate_char_type.dat (+14/-0)
tests/std_data/mysqlmigrate_comments.dat (+10/-0)
tests/std_data/mysqlmigrate_databases.dat (+10/-0)
tests/std_data/mysqlmigrate_date_type.dat (+14/-0)
tests/std_data/mysqlmigrate_datetime_type.dat (+14/-0)
tests/std_data/mysqlmigrate_decimal_type.dat (+18/-0)
tests/std_data/mysqlmigrate_double_type.dat (+14/-0)
tests/std_data/mysqlmigrate_engines.dat (+6/-0)
tests/std_data/mysqlmigrate_enum_type.dat (+15/-0)
tests/std_data/mysqlmigrate_float_type.dat (+21/-0)
tests/std_data/mysqlmigrate_foreign_key.dat (+4/-0)
tests/std_data/mysqlmigrate_indexes.dat (+3/-0)
tests/std_data/mysqlmigrate_integer_type.dat (+67/-0)
tests/std_data/mysqlmigrate_large_data.dat (+230/-0)
tests/std_data/mysqlmigrate_numeric_type.dat (+18/-0)
tests/std_data/mysqlmigrate_partitions.dat (+2/-0)
tests/std_data/mysqlmigrate_real_type.dat (+18/-0)
tests/std_data/mysqlmigrate_set_type.dat (+15/-0)
tests/std_data/mysqlmigrate_text_type.dat (+41/-0)
tests/std_data/mysqlmigrate_time_type.dat (+16/-0)
tests/std_data/mysqlmigrate_timestamp_type.dat (+12/-0)
tests/std_data/mysqlmigrate_varbinary_type.dat (+14/-0)
tests/std_data/mysqlmigrate_varchar_type.dat (+14/-0)
tests/std_data/mysqlmigrate_year_type.dat (+18/-0)
tests/suite/mysql_migrate/README (+7/-0)
tests/suite/mysql_migrate/include/drizzledump_migrate.inc (+45/-0)
tests/suite/mysql_migrate/include/mysql_cleanup.inc (+4/-0)
tests/suite/mysql_migrate/r/all_databases.result (+84/-0)
tests/suite/mysql_migrate/r/basic.result (+20/-0)
tests/suite/mysql_migrate/r/binary_type.result (+26/-0)
tests/suite/mysql_migrate/r/bit_type.result (+29/-0)
tests/suite/mysql_migrate/r/blob_type.result (+67/-0)
tests/suite/mysql_migrate/r/char_type.result (+25/-0)
tests/suite/mysql_migrate/r/comments.result (+33/-0)
tests/suite/mysql_migrate/r/databases.result (+70/-0)
tests/suite/mysql_migrate/r/date_type.result (+25/-0)
tests/suite/mysql_migrate/r/datetime_type.result (+25/-0)
tests/suite/mysql_migrate/r/decimal_type.result (+27/-0)
tests/suite/mysql_migrate/r/destination-database.result (+35/-0)
tests/suite/mysql_migrate/r/engines.result (+29/-0)
tests/suite/mysql_migrate/r/enum_type.result (+26/-0)
tests/suite/mysql_migrate/r/float_type.result (+30/-0)
tests/suite/mysql_migrate/r/foreign_key.result (+28/-0)
tests/suite/mysql_migrate/r/indexes.result (+29/-0)
tests/suite/mysql_migrate/r/integer_type.result (+103/-0)
tests/suite/mysql_migrate/r/large_data.result (+1601/-0)
tests/suite/mysql_migrate/r/numeric_type.result (+27/-0)
tests/suite/mysql_migrate/r/partitions.result (+21/-0)
tests/suite/mysql_migrate/r/real_type.result (+27/-0)
tests/suite/mysql_migrate/r/set_type.result (+27/-0)
tests/suite/mysql_migrate/r/text_type.result (+67/-0)
tests/suite/mysql_migrate/r/time_type.result (+27/-0)
tests/suite/mysql_migrate/r/timestamp_type.result (+23/-0)
tests/suite/mysql_migrate/r/varchar_type.result (+25/-0)
tests/suite/mysql_migrate/r/year_type.result (+30/-0)
tests/suite/mysql_migrate/t/all_databases.test (+90/-0)
tests/suite/mysql_migrate/t/basic.test (+16/-0)
tests/suite/mysql_migrate/t/binary_type.test (+16/-0)
tests/suite/mysql_migrate/t/bit_type.test (+16/-0)
tests/suite/mysql_migrate/t/blob_type.test (+31/-0)
tests/suite/mysql_migrate/t/char_type.test (+16/-0)
tests/suite/mysql_migrate/t/comments.test (+18/-0)
tests/suite/mysql_migrate/t/databases.test (+78/-0)
tests/suite/mysql_migrate/t/date_type.test (+16/-0)
tests/suite/mysql_migrate/t/datetime_type.test (+16/-0)
tests/suite/mysql_migrate/t/decimal_type.test (+16/-0)
tests/suite/mysql_migrate/t/destination-database.test (+56/-0)
tests/suite/mysql_migrate/t/double_type.test (+16/-0)
tests/suite/mysql_migrate/t/engines.test (+21/-0)
tests/suite/mysql_migrate/t/enum_type.test (+16/-0)
tests/suite/mysql_migrate/t/float_type.test (+16/-0)
tests/suite/mysql_migrate/t/foreign_key.test (+17/-0)
tests/suite/mysql_migrate/t/indexes.test (+17/-0)
tests/suite/mysql_migrate/t/integer_type.test (+36/-0)
tests/suite/mysql_migrate/t/large_data.test (+26/-0)
tests/suite/mysql_migrate/t/master.opt (+1/-0)
tests/suite/mysql_migrate/t/numeric_type.test (+16/-0)
tests/suite/mysql_migrate/t/partitions.test (+16/-0)
tests/suite/mysql_migrate/t/real_type.test (+16/-0)
tests/suite/mysql_migrate/t/set_type.test (+16/-0)
tests/suite/mysql_migrate/t/text_type.test (+31/-0)
tests/suite/mysql_migrate/t/time_type.test (+16/-0)
tests/suite/mysql_migrate/t/timestamp_type.test (+16/-0)
tests/suite/mysql_migrate/t/varbinary_type.test (+16/-0)
tests/suite/mysql_migrate/t/varchar_type.test (+16/-0)
tests/suite/mysql_migrate/t/year_type.test (+16/-0)
lp:~linuxjedi/drizzle/trunk-drizzledump-bugs-part2
- Lee Bieber (community): Needs Fixing
-
Diff: 138 lines (+20/-21)5 files modifiedclient/drizzledump.cc (+5/-6)
client/drizzledump_data.cc (+5/-0)
client/drizzledump_data.h (+1/-0)
client/drizzledump_drizzle.cc (+2/-2)
client/drizzledump_mysql.cc (+7/-13)
| Changed in drizzle: | |
| assignee: | nobody → Andrew Hutchings (linuxjedi) |
| status: | New → Confirmed |
Revision history for this message
| Andrew Hutchings (linuxjedi) wrote | #1 |
To post a comment you must log in.
support for this appears to be missing :/