Editing recipe oopses if invalid branch used
Bug #683321 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Steve Kowalik |
Bug Description
While invalid branches are handled gracefully when creating recipes, they cause oopses when editing recipes. The error handling edit vs add should be uniform.
Related branches
lp:~abentley/launchpad/recipe-errors
Rejected
for merging
into
lp:launchpad
- Jeroen T. Vermeulen (community): Needs Fixing (code)
-
Diff: 126 lines (+48/-35)2 files modifiedlib/lp/code/browser/sourcepackagerecipe.py (+37/-35)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+11/-0)
lp:~stevenk/launchpad/set-recipe-text-bad-data
- Robert Collins (community): Approve
-
Diff: 141 lines (+51/-45)2 files modifiedlib/lp/code/browser/sourcepackagerecipe.py (+38/-45)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+13/-0)
tags: |
added: recipe removed: code-review |
Changed in launchpad: | |
importance: | High → Critical |
Changed in launchpad: | |
assignee: | nobody → Aaron Bentley (abentley) |
Changed in launchpad: | |
assignee: | Aaron Bentley (abentley) → Steve Kowalik (stevenk) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12385 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12385>.