Fom

The FakeFluidDB class doesn't escape URI correctly thus allowing introduction of bugs that pass unit tests (e.g. PermissionsApi)

Bug #683111 reported by Nicholas Tollervey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fom
Fix Released
High
Nicholas Tollervey

Bug Description

It centres round the _generate_endpoint_url method in db.py.

GIven the following path list (as generated by PermissionsApi):

['permissions/namespaces', 'foo']

Using _generate_endpoint_url will escape the slash in the first item (between 'permissions' and 'namespaces') resulting in a path like this:

/permissions%2Fnamespaces/foo

The FakeFluidDB class simply "/".join() s them together resulting in the following (valid but incorrectly generated) path:

/permissions/namespaces/foo

In order to fix the bug in the PermissionsApi, the FakeFluidDB class should be made to mirror *exactly* the behaviour of the real FluidDB class when generating URL paths.

Related branches

Changed in fom:
assignee: nobody → Nicholas Tollervey (ntoll)
status: New → In Progress
milestone: none → 10.11
importance: Undecided → High
Revision history for this message
Nicholas Tollervey (ntoll) wrote :

OK... In the related branch I've also fixed the following that were causing the unit tests to fail.

1) The PermissionsApi as mentioned above
2) The AboutObjectsApi
3) The TagsApi

Jamu Kakar (jkakar)
Changed in fom:
milestone: 10.11 → 10.12
Changed in fom:
status: In Progress → Fix Committed
Changed in fom:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.