The FakeFluidDB class doesn't escape URI correctly thus allowing introduction of bugs that pass unit tests (e.g. PermissionsApi)
Bug #683111 reported by
Nicholas Tollervey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fom |
Fix Released
|
High
|
Nicholas Tollervey |
Bug Description
It centres round the _generate_
GIven the following path list (as generated by PermissionsApi):
['permissions/
Using _generate_
/permissions%
The FakeFluidDB class simply "/".join() s them together resulting in the following (valid but incorrectly generated) path:
/permissions/
In order to fix the bug in the PermissionsApi, the FakeFluidDB class should be made to mirror *exactly* the behaviour of the real FluidDB class when generating URL paths.
Related branches
lp:~ntoll/fom/mend-fakefluiddb-683111
- Jamu Kakar: Approve
-
Diff: 152 lines (+41/-16)4 files modifiedfom/api.py (+2/-2)
tests/_base.py (+6/-7)
tests/test_api.py (+7/-7)
tests/test_base.py (+26/-0)
Changed in fom: | |
assignee: | nobody → Nicholas Tollervey (ntoll) |
status: | New → In Progress |
milestone: | none → 10.11 |
importance: | Undecided → High |
Changed in fom: | |
milestone: | 10.11 → 10.12 |
Changed in fom: | |
status: | In Progress → Fix Committed |
Changed in fom: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
OK... In the related branch I've also fixed the following that were causing the unit tests to fail.
1) The PermissionsApi as mentioned above
2) The AboutObjectsApi
3) The TagsApi